1155598 - [Flame][E.me Integration]The arrow of suggestion dialog is not centered.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Verson Xiong (Leave from Mozilla)]

Attachment: Compare.png

[1.Description]:
[Flame][v2.2][E.me Integration]When you use  E.me to serch something,  the arrow of  suggestion dialog is left aligned and points to nothing.
Found time:07:34
See attachment:logcat_0734.txt & compare.png

[2.Testing Steps]: 
1. Flash device.
2. Connect to an available network.
3. Tap E.me from homescreen.
4. Input any letters, such as "ser".
5. Check  suggestion dialog.

[3.Expected Result]: 
5.The arrow of suggestion dialog  should be centered.

[4.Actual Result]: 
5.The arrow of suggestion dialog is not centered.

[5.Reproduction build]: 
Flame 2.2 version(Affected):
Build ID               20150416162504
Gaia Revision          d50b8a3919a7b4d8d289f150d3b9bed704ebafa9
Gaia Date              2015-04-16 21:46:57
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5ebf32030512
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150416.195720
Firmware Date          Thu Apr 16 19:57:29 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0version(Unaffected):
Build ID               20150416160206
Gaia Revision          3cd0a9facce26c2acc7be3755a17131a6358e33f
Gaia Date              2015-04-16 16:33:22
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/51e3cb11a258
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150416.191700
Firmware Date          Thu Apr 16 19:17:10 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Verson Xiong (Leave from Mozilla)]

Attachment: logcat_0734.txt

Comment 2

[Hermes Cheng (inactive after July 27, 2015)]

It needs to be fixed. Kevin, could you help?

Comment 3

[Kevin Grandon :kgrandon]

Since this is fixed in master, and broken in 2.2, can we do a reverse regression window to find the commit which fixed this?

Comment 4

[Yeojin Chung [:YeojinC]]

This issue has never appeared on Master. The patch for Bug 1129701 on 2.2 might be the cause of the regression in Mozilla-b2g37.

Mozilla-b2g37 Regression Window:

Last Working Environmental Variables:
Device: Flame 2.2
BuildID: 20150324172513
Gaia: 7024dd4c7a7c3616dc8f9f908759f00abc0deddd
Gecko: 3297c641e7e5
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

First Broken Environmental Variables:
Device: Flame 2.2
BuildID: 20150324191139
Gaia: d225db9622d6e308af02880f43628dcf2f3f9bbe
Gecko: 41b422df890b
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: 7024dd4c7a7c3616dc8f9f908759f00abc0deddd
Gecko: 41b422df890b

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: d225db9622d6e308af02880f43628dcf2f3f9bbe
Gecko: 3297c641e7e5

https://github.com/mozilla-b2g/gaia/compare/7024dd4c7a7c3616dc8f9f908759f00abc0deddd...d225db9622d6e308af02880f43628dcf2f3f9bbe

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Alberto, can you take a look at this please? This might have been caused by the uplift for bug 1129701.

Comment 6

[Gregor Wagner [:gwagner]]

Lets ask for uplift approval.

Comment 7

[Alberto Pastor [:albertopq]]

The same gaia code in 3.0 works fine, but in 2.2 doesn't. I'll try to find a workaround in gaia, but I would like to know what gecko patch fixed it in 3.0. Can we search the regression-window in gecko?
Thanks!

Comment 8

[Alissa（leave from Mozilla）]

According to the STR of comment 0

b2g-inbound Regression Window:

First Working Environmental Variables:
Flame 3.0
Build-ID        20150325102244
Version         39.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150324.193523
FW-Date         Tue Mar 24 19:35:34 EDT 2015
Bootloader      L1TC000118D0

Last Broken Environmental Variables:
Flame3.0
Build-ID        20150325101835
Version         39.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150324.193523
FW-Date         Tue Mar 24 19:35:34 EDT 2015
Bootloader      L1TC000118D0

Last Broken Gecko & First Working Gaia-Issue does reproduce 
Gaia-Rev        508b8d48fb5ecf08bf0e5b4fef42bc48b770e7f2
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/4a2d03fece0e


Last Broken Gaia & First Working Gecko-Issue does NOT reproduce 
Gaia-Rev        508b8d48fb5ecf08bf0e5b4fef42bc48b770e7f2 
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/cdd2cf9d2d4e

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1155598-center-arrow > mozilla-b2g:master

Comment 10

[Alissa（leave from Mozilla）]

(In reply to Alberto Pastor [:albertopq] from comment #7)
According to the STR of comment 0

Mozilla-inbound Regression Window:

Last Broken Environmental Variables:
Device: Flame 3.0
Gaia-Rev        00d50b78a7a99de5b0b55309a467807c677e2a66
Gecko-Rev       https://hg.mozilla.org/integration/mozilla-inbound/rev/6796d08c38c1    
Build-ID        20150324153318
Version         39.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150324.193523
FW-Date         Tue Mar 24 19:35:34 EDT 2015
Bootloader      L1TC000118D0

First Working Environmental Variables:
Device: Flame 3.0
Gaia-Rev        00d50b78a7a99de5b0b55309a467807c677e2a66
Gecko-Rev       https://hg.mozilla.org/integration/mozilla-inbound/rev/cba35d1eae6a
Build-ID        20150324154015
Version         39.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150324.193523
FW-Date         Tue Mar 24 19:35:34 EDT 2015
Bootloader      L1TC000118D0

Last Broken Gecko & First Working Gaia:  Issue does reproduce 
Gaia-Rev        00d50b78a7a99de5b0b55309a467807c677e2a66
Gecko-Rev       https://hg.mozilla.org/integration/mozilla-inbound/rev/6796d08c38c1   

Last Broken Gaia & First Working Gecko:  Issue does NOT reproduce 
Gaia-Rev        00d50b78a7a99de5b0b55309a467807c677e2a66
Gecko-Rev       https://hg.mozilla.org/integration/mozilla-inbound/rev/cba35d1eae6a

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8595806 [details] [review]
[gaia] albertopq:1155598-center-arrow > mozilla-b2g:master

LGTM, but does this work well with RTL as well? Just wondering if we need to add another selector and have a "left: unset;" thing somewhere.

Comment 12

[Alberto Pastor [:albertopq]]

It should work (it will be in the center in both cases), but I changed it to use -moz-margin-start to make it clearer.

Thanks!

Comment 13

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/04ccfe95763b230d19da825fe715351e629649d0

Comment 14

[Hermes Cheng (inactive after July 27, 2015)]

Could you also uplift to 2.2?

Comment 15

[Alberto Pastor [:albertopq]]

Comment on attachment 8595806 [details] [review]
[gaia] albertopq:1155598-center-arrow > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1129701 (in 2.2 only)
[User impact] if declined: The arrow is not centered on the suggestions warning
[Testing completed]: Manually tested in 3.0 and 2.2 (both rtl and ltr)
[Risk to taking this patch] (and alternatives if risky): CSS one liner. Low risk.
[String changes made]: none

Comment 16

[bhavana bajaj [:bajaj]]

Comment on attachment 8595806 [details] [review]
[gaia] albertopq:1155598-center-arrow > mozilla-b2g:master

Approving this only because its a regression and low risk change.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/d935a30071c630196be36c0b2546a9c2651314ea

Comment 18

[Verson Xiong (Leave from Mozilla)]

This issue is verified fixed on latest build of Flame 2.2/3.0,he STR is same as Comment 0.
Reproduce rate:0/5

Flame 2.2(Fixed):
Build ID               20150426002504
Gaia Revision          265ca0bc9408c21fc4b25a259fcee7fb642cd06b
Gaia Date              2015-04-24 19:13:28
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1908685d798d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150426.043030
Firmware Date          Sun Apr 26 04:30:42 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0(Fixed):
Build ID               20150426160201
Gaia Revision          b4c949cdc780893897c9b45c1adea46e2eb694ff
Gaia Date              2015-04-24 16:13:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/37d60e3b8be6
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150426.193323
Firmware Date          Sun Apr 26 19:33:34 EDT 2015
Bootloader             L1TC000118D0