If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use std::max instead of max macro in cubeb_wasapi.cpp.

RESOLVED FIXED in Firefox 40

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla40
x86_64
Windows
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8593900 [details] [diff] [review]
fix

We build with -DNOMINMAX on mingw, so the macro is not available there. The attached patch uses std::max templated function instead.
Attachment #8593900 - Flags: review?(kinetik)
Attachment #8593900 - Flags: review?(kinetik) → review+

Comment 1

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/97c7b5c07014

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cd59e599f3a
https://hg.mozilla.org/mozilla-central/rev/97c7b5c07014
https://hg.mozilla.org/mozilla-central/rev/9cd59e599f3a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.