Open Bug 1155640 Opened 10 years ago Updated 2 years ago

Private window's chrome is no longer darkened on Mac OSX 10.10

Categories

(Firefox :: Theme, defect)

x86
macOS
defect

Tracking

()

People

(Reporter: ehsan.akhgari, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Now the area behind the tab bar looks translucent like normal windows. Markus, is this a change that you've recently made?
Flags: needinfo?(mstange)
Madhava, is this change OK with the UX team? I'm personally fine either way, just want to make sure that this is intentional.
Flags: needinfo?(madhava)
Bug 1160823 is a good way to fix this.
Depends on: 1160823
Flags: needinfo?(mstange)
The change to use vibrancy in the title bar was made in bug 1052466.
Depends on: 1163186
Assignee: nobody → ehsan
Flags: needinfo?(madhava)
Attachment #8603594 - Flags: review?(dao)
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #5) > Created attachment 8603594 [details] [diff] [review] > Make the titlebar of private windows use a dark vibrancy color where > supported Shouldn't the color be set to white as well ?
Blocks: 1109349
(In reply to Tim Nguyen [:ntim] (limited availability) from comment #6) > (In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from > comment #5) > > Created attachment 8603594 [details] [diff] [review] > > Make the titlebar of private windows use a dark vibrancy color where > > supported > > Shouldn't the color be set to white as well ? Yeah, but that is something that we need to fix in the widget layer, since the OS draws the title text for us. Bug 1163186 covers that
Attachment #8603594 - Flags: review?(dao) → review+
Assignee: ehsan → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: