Closed Bug 1155642 Opened 9 years ago Closed 9 years ago

Windows XP showing several tiny icons per toolbar button when using Luna Silver with high DPI

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Version:
40 Branch
Platform:
x86_64
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Iteration:
40.2 - 27 Apr
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: Gijs, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

weird-xp-icons.PNG
17.90 KB, image/png
Details
possible patch
838 bytes, patch
Gijs
: review+
Details | Diff | Splinter Review
Attached image weird-xp-icons.PNG — 
Dao, any ideas on how I can debug this? This reproduces on a clean profile for me in my XP vm...
Flags: qe-verify-
Flags: needinfo?
Flags: in-testsuite-
Flags: firefox-backlog+
Now with correct needinfo...
Flags: needinfo? → needinfo?(dao)
Version: 35 Branch → 40 Branch
That's with increased DPI? Looks like we're using the image regions for Toolbar@2x.png but Toolbar-lunaSilver.png as the image.
Blocks: 1147702
Flags: needinfo?(dao)
Keywords: regressionwindow-wanted
Summary: Windows XP showing several tiny icons per toolbar button on current nightly → Windows XP showing several tiny icons per toolbar button when using Luna Silver with high DPI
Attached patch possible patch — — Splinter Review 
Does this help?
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8594295 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8594295 [details] [diff] [review]
possible patch

Review of attachment 8594295 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, that helps. Thanks!
Attachment #8594295 - Flags: review?(gijskruitbosch+bugs) → review+
Iteration: --- → 40.2 - 27 Apr
Points: --- → 1
https://hg.mozilla.org/mozilla-central/rev/a787c9daa1b9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: