1155664 - buildbotcustom code cleanup

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

Attachment: cleanup-buildbotcustom.diff

Based on recent coverage data, we can rip out this old code.

Also, I found that we were spending a ton of time in deepcopy() calls. The patch moves what parts of the test builder config that we're copying. This cuts my checkconfig time nearly in half, and reduces memory usage by about 10%.

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 8593963 [details] [diff] [review]
cleanup-buildbotcustom.diff

Review of attachment 8593963 [details] [diff] [review]:
-----------------------------------------------------------------

as said in IRC the deepcopy removal concerns me, just in terms of "making footguns easier to fire", but I'm not convinced we should optimize around our own footguns.

f+ until I have time to think harder, or someone else r+'s

Comment 2

[Chris AtLee [:catlee]]

Attachment: cleanup-buildbotcustom-1.diff

basically the same thing, but adds some asserts that we're not hitting old code paths, nor duplicating arguments.

Comment 3

[Jordan Lund (:jlund)]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/a2e870ab70a4