Closed Bug 1155684 Opened 5 years ago Closed 5 years ago

Remove any mentions of reading list sync

Categories

(Firefox for Android Graveyard :: Reading List, defect)

All
Android
defect
Not set

Tracking

(firefox38 verified, firefox38.0.5 verified, firefox39 fixed, firefox40 fixed, fennec38+)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox38 --- verified
firefox38.0.5 --- verified
firefox39 --- fixed
firefox40 --- fixed
fennec 38+ ---

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

This bug tracks removing any changes we made that mention reading list sync from 38+.

* Sync adapter name string
* Sync adapter entry
* Settings changes
* Any "Sign in to get your reading list…" changes
* …
* Profit
* Remove the syncing build flag, too.
Blocks: 1155683
tracking-fennec: --- → 38+
Keep in mind, we don't know what timeline we have for adding this back. Could be soon. Could be using a 3rd party server-side platform. Don't remove what can easily be disabled, until we get a more concrete plan.
Attached file Pull req.
Untested. Also needs the flag to be flipped in confvars.
Attachment #8594195 - Flags: review?(nalexander)
Comment on attachment 8594195 [details] [review]
Pull req.

I see no obvious issues.
Attachment #8594195 - Flags: review?(nalexander) → review+
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Keep in mind, we don't know what timeline we have for adding this back.
> Could be soon. Could be using a 3rd party server-side platform. Don't remove
> what can easily be disabled, until we get a more concrete plan.

Yup. This just removes the SyncAdapter from the manifest, avoids us doing RL-ish work in account upgrades, and otherwise relies on flipping the flag.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
[leave open] so we can evaluate on Nightly to determine if additional UI changes etc. are necessary.
Whiteboard: [leave open]
Did this look good in Nightly, Nick?
Flags: needinfo?(nalexander)
(In reply to Richard Newman [:rnewman] from comment #9)
> Did this look good in Nightly, Nick?

Yes!  Verified by:

1) install [1];
2) create a Firefox Account;
3) verify that Reading List sync is present in Firefox Account Status activity;
4) install [2] over top;
5) verify that Reading List sync is no longer present in Firefox Account Status activity and Android Settings > Accounts section;
6) verify that FxReading no longer appears in |adb logcat| during a Sync Now from the Status activity.

[1] http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2015-04-20-03-02-04-mozilla-central-android-api-11/fennec-40.0a1.multi.android-arm.apk
[2] http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2015-04-22-03-02-06-mozilla-central-android-api-11/fennec-40.0a1.multi.android-arm.apk
Flags: needinfo?(nalexander)
Comment on attachment 8594195 [details] [review]
Pull req.

Thanks for the verification, Nick!

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
  Users have a syncing reading list.

[Describe test coverage new/current, TreeHerder]:
  Manual verification on Nightly.

[Risks and why]: 
  Turning off the RL we just landed.

[String/UUID change made/needed]:
  None.
Attachment #8594195 - Flags: approval-mozilla-release?
Attachment #8594195 - Flags: approval-mozilla-beta?
Attachment #8594195 - Flags: approval-mozilla-aurora?
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Comment on attachment 8594195 [details] [review]
Pull req.

Should be in 38.0b8
Attachment #8594195 - Flags: approval-mozilla-release?
Attachment #8594195 - Flags: approval-mozilla-release+
Attachment #8594195 - Flags: approval-mozilla-beta?
Attachment #8594195 - Flags: approval-mozilla-beta+
Attachment #8594195 - Flags: approval-mozilla-aurora?
Attachment #8594195 - Flags: approval-mozilla-aurora+
Target Milestone: --- → Firefox 40
Verified the steps from comment #10 on Firefox 38.0b8
Still needs to be verified on Nightly and Aurora
Verified as fixed on 38.0.5b4
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.