1155684 - Remove any mentions of reading list sync

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reading List, defect)

Description

[Richard Newman [:rnewman]]

This bug tracks removing any changes we made that mention reading list sync from 38+.

* Sync adapter name string
* Sync adapter entry
* Settings changes
* Any "Sign in to get your reading list…" changes
* …
* Profit

Comment 1

[Richard Newman [:rnewman]]

* Remove the syncing build flag, too.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Keep in mind, we don't know what timeline we have for adding this back. Could be soon. Could be using a 3rd party server-side platform. Don't remove what can easily be disabled, until we get a more concrete plan.

Comment 3

[Richard Newman [:rnewman]]

Attachment: Pull req.

Untested. Also needs the flag to be flipped in confvars.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8594195 [details] [review]
Pull req.

I see no obvious issues.

Comment 5

[Richard Newman [:rnewman]]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Keep in mind, we don't know what timeline we have for adding this back.
> Could be soon. Could be using a 3rd party server-side platform. Don't remove
> what can easily be disabled, until we get a more concrete plan.

Yup. This just removes the SyncAdapter from the manifest, avoids us doing RL-ish work in account upgrades, and otherwise relies on flipping the flag.

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/9c86af820755
https://hg.mozilla.org/integration/fx-team/rev/45d4e3c9ff6b

Comment 7

[Richard Newman [:rnewman]]

[leave open] so we can evaluate on Nightly to determine if additional UI changes etc. are necessary.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c86af820755
https://hg.mozilla.org/mozilla-central/rev/45d4e3c9ff6b

Comment 9

[Richard Newman [:rnewman]]

Did this look good in Nightly, Nick?

Comment 10

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #9)
> Did this look good in Nightly, Nick?

Yes!  Verified by:

1) install [1];
2) create a Firefox Account;
3) verify that Reading List sync is present in Firefox Account Status activity;
4) install [2] over top;
5) verify that Reading List sync is no longer present in Firefox Account Status activity and Android Settings > Accounts section;
6) verify that FxReading no longer appears in |adb logcat| during a Sync Now from the Status activity.

[1] http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2015-04-20-03-02-04-mozilla-central-android-api-11/fennec-40.0a1.multi.android-arm.apk
[2] http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2015-04-22-03-02-06-mozilla-central-android-api-11/fennec-40.0a1.multi.android-arm.apk

Comment 11

[Richard Newman [:rnewman]]

Comment on attachment 8594195 [details] [review]
Pull req.

Thanks for the verification, Nick!

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
  Users have a syncing reading list.

[Describe test coverage new/current, TreeHerder]:
  Manual verification on Nightly.

[Risks and why]: 
  Turning off the RL we just landed.

[String/UUID change made/needed]:
  None.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8594195 [details] [review]
Pull req.

Should be in 38.0b8

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f1abc2f6c7b3
https://hg.mozilla.org/releases/mozilla-aurora/rev/2770039fc3a0

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/18c8180670c7
https://hg.mozilla.org/releases/mozilla-release/rev/309ed42a5999

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/18c8180670c7
https://hg.mozilla.org/releases/mozilla-beta/rev/309ed42a5999

Comment 16

[Catalin Suciu [:csuciu]]

Verified the steps from comment #10 on Firefox 38.0b8
Still needs to be verified on Nightly and Aurora

Comment 17

[Catalin Suciu [:csuciu]]

Verified as fixed on 38.0.5b4