Replace FrameSendFailureError and FrameSendNotInitializedError with NoSuchWindowError in Marionette server

RESOLVED FIXED in Firefox 40

Status

Testing
Marionette
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

(Blocks: 1 bug, {ateam-marionette-client, ateam-marionette-server})

unspecified
mozilla40
ateam-marionette-client, ateam-marionette-server
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
We have two errors, FrameSendFailureError and FrameSendNotInitializedError, that are not in compliance with Selenium.  It seems we should be able to replace them with NoSuchWindowError to do what Selenium expects.

Unfortunately they are widely used in Gaia, so I suggest the following risk management plan:

1. Land a NoSuchWindowException symbol in marionette_driver
2. Upgrade marionette_driver in Gaia and include that symbol anywhere those two exceptions are currently used
3. Change the server to use the new error and remove the outdated ones
4. Remove the outdated exceptions from Gaia
5. Remove the outdated exception symbols from marionette_driver

Sound good?
(Assignee)

Updated

3 years ago
Blocks: 721859
Keywords: ateam-marionette-client, ateam-marionette-server
(Assignee)

Updated

3 years ago
Depends on: 1159674
(Assignee)

Comment 1

3 years ago
1. NoSuchWindowException has already landed in marionette-driver.
2a. The marionette-driver in Gaia has a sufficiently recent version.
2b. https://github.com/mozilla-b2g/gaia/pull/29794 (bug 1159674) introduces NoSuchWindowException
Assignee: nobody → ato
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8599252 [details]
MozReview Request: bz://1155703/ato

/r/7839 - Bug 1155703: Part 1: Correct Marionette to use NoSuchWindowError
/r/7841 - Bug 1159674: Part 2: Remove frame send exceptions from Marionette client

Pull down these commits:

hg pull -r 4c754ffa813d1d5dea0db9909d86b5c27156fcd1 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599252 - Flags: review?(dave.hunt)
https://reviewboard.mozilla.org/r/7841/#review6623

Looks good, but we should make sure we have a passing Gip try run before landing this, as it depends on another patch to land first.
(Assignee)

Comment 5

3 years ago
Yes, just to be explicit we're expecting the Gip tests to fail until bug 1159674 lands in Gaia and the Gaia reference is bumped on central.
Comment on attachment 8599252 [details]
MozReview Request: bz://1155703/ato

https://reviewboard.mozilla.org/r/7837/#review6625
Attachment #8599252 - Flags: review?(dave.hunt) → review+
(Assignee)

Updated

3 years ago
Blocks: 1162515
(Assignee)

Updated

3 years ago
No longer blocks: 1162515
(Assignee)

Updated

3 years ago
Summary: Replace FrameSendFailureError and FrameSendNotInitializedError with NoSuchWindowError → Replace FrameSendFailureError and FrameSendNotInitializedError with NoSuchWindowError in Marionette server
https://hg.mozilla.org/mozilla-central/rev/d00a52f922ed
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
(Assignee)

Comment 11

3 years ago
Comment on attachment 8599252 [details]
MozReview Request: bz://1155703/ato
Attachment #8599252 - Attachment is obsolete: true
Attachment #8620081 - Flags: review+
Attachment #8620082 - Flags: review+
(Assignee)

Comment 12

3 years ago
Created attachment 8620081 [details]
MozReview Request: Bug 1159674: Part 2: Remove frame send exceptions from Marionette client
(Assignee)

Comment 13

3 years ago
Created attachment 8620082 [details]
MozReview Request: Bug 1155703: Part 1: Correct Marionette to use NoSuchWindowError
You need to log in before you can comment on or make changes to this bug.