Closed Bug 1155716 Opened 5 years ago Closed 5 years ago

Remove submitElement command

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

(Keywords: pi-marionette-client, pi-marionette-server)

Attachments

(2 files, 1 obsolete file)

There's no command to submit elements on a form in the W3C WebDriver protocol.  We should move our tests over to not using this function, deprecate it in the Python and Node.js clients, and eventually (this bug) remove it from the Marionette server.
Further investigation shows that Gaia isn't using HTMLElement#submit at all and that the marionette-js-client doesn't implement submitElement at all.

That means we can simply remove it from the Python client and the Marionette server in one go.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attached file MozReview Request: bz://1155716/ato (obsolete) —
/r/7833 - Bug 1155716: Part 1: Remove submitElement from Marionette
/r/7835 - Bug 1155716: Part 2: Remove HTMLElement#submit from marionette-driver

Pull down these commits:

hg pull -r add8e8f8007640c2edbd072ecd4d4e9431cce6b6 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599236 - Flags: review?(dburns)
Attachment #8599236 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/786dc785bae6
https://hg.mozilla.org/mozilla-central/rev/b1ed7125efa7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Attachment #8599236 - Attachment is obsolete: true
Attachment #8620083 - Flags: review+
Attachment #8620084 - Flags: review+
You need to log in before you can comment on or make changes to this bug.