Closed
Bug 1155716
Opened 9 years ago
Closed 9 years ago
Remove submitElement command
Categories
(Testing :: Marionette Client and Harness, defect)
Testing
Marionette Client and Harness
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-client, pi-marionette-server)
Attachments
(2 files, 1 obsolete file)
There's no command to submit elements on a form in the W3C WebDriver protocol. We should move our tests over to not using this function, deprecate it in the Python and Node.js clients, and eventually (this bug) remove it from the Marionette server.
Assignee | ||
Updated•9 years ago
|
Keywords: ateam-marionette-client,
ateam-marionette-server
Assignee | ||
Comment 1•9 years ago
|
||
Further investigation shows that Gaia isn't using HTMLElement#submit at all and that the marionette-js-client doesn't implement submitElement at all. That means we can simply remove it from the Python client and the Marionette server in one go.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
/r/7833 - Bug 1155716: Part 1: Remove submitElement from Marionette /r/7835 - Bug 1155716: Part 2: Remove HTMLElement#submit from marionette-driver Pull down these commits: hg pull -r add8e8f8007640c2edbd072ecd4d4e9431cce6b6 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599236 -
Flags: review?(dburns)
Assignee | ||
Comment 3•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1f523e04361
Updated•9 years ago
|
Attachment #8599236 -
Flags: review?(dburns) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8599236 [details] MozReview Request: bz://1155716/ato https://reviewboard.mozilla.org/r/7831/#review6635
https://hg.mozilla.org/integration/mozilla-inbound/rev/786dc785bae6 https://hg.mozilla.org/integration/mozilla-inbound/rev/b1ed7125efa7
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/786dc785bae6 https://hg.mozilla.org/mozilla-central/rev/b1ed7125efa7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8599236 -
Attachment is obsolete: true
Attachment #8620083 -
Flags: review+
Attachment #8620084 -
Flags: review+
Assignee | ||
Comment 8•9 years ago
|
||
Assignee | ||
Comment 9•9 years ago
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
Comment 10•1 year ago
|
||
Moving bugs for Marionette client due to component changes.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•