Generate playback rate options in Javascript

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(firefox40 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8594005 [details]
Screenshot 2015-04-17 08.49.34.png

We currently have the following HTML in every event page:


<span class="playbackrate">
  <a class="open inactive"
     title="Click to see playback rate options"></a>
  <span class="options">
    <a data-rate="0.5" title="Half the speed">0.5&times;</a>
    <a data-rate="1" title="Normal speed">1&times;</a>
    <a data-rate="1.5" title="One and a half the speed">1.5&times;</a>
    <a data-rate="2" title="Double speed">2&times;</a>
  </span>
</span>

A disadvantage with that is that it's so early in the HTML hierarchy that it shows up in the Google Search results (shame Google prefers that instead of the Open Graph description).

Let's generate this on-the-fly with jquery instead.
(Assignee)

Updated

3 years ago
Assignee: nobody → peterbe
Status: NEW → ASSIGNED

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/684286a08d3b0ade3b69653a7641254f7052bc76
fixes bug 1155721 - Generate playback rate options in Javascript

https://github.com/mozilla/airmozilla/commit/56b9f18269f0ad39aa9172cf11cef2c3843734d6
Merge pull request #277 from peterbe/bug-1155721-generate-playback-rate-options-in-javascript

fixes bug 1155721 - Generate playback rate options in Javascript

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

3 years ago
This broke the event edit page.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

3 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.