OdinMonkey: add new cache failure code for when storage initialization fails

RESOLVED FIXED in Firefox 40

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8594008 [details] [diff] [review]
new-error-message

It looks like in some cases the we're having asm.js caching failures caused by initialization of the underlying storage system.  Add a separate error message (from the generic "internal error" message) for this.
Attachment #8594008 - Flags: review?(Jan.Varga)

Comment 1

3 years ago
Comment on attachment 8594008 [details] [diff] [review]
new-error-message

Review of attachment 8594008 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/asmjscache/AsmJSCache.cpp
@@ +767,1 @@
>    NS_ENSURE_SUCCESS(rv, rv);

Uhm, you want to keep the NS_ENSURE_SUCCESS too ?
(Assignee)

Comment 2

3 years ago
Created attachment 8594079 [details] [diff] [review]
new-error-message

Oops, nope, that can go.
Attachment #8594008 - Attachment is obsolete: true
Attachment #8594008 - Flags: review?(Jan.Varga)
Attachment #8594079 - Flags: review?(Jan.Varga)

Updated

3 years ago
Attachment #8594079 - Flags: review?(Jan.Varga) → review+
https://hg.mozilla.org/mozilla-central/rev/905f210de15b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.