Closed Bug 1155726 Opened 9 years ago Closed 9 years ago

OdinMonkey: add new cache failure code for when storage initialization fails

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch new-error-message (obsolete) — Splinter Review
It looks like in some cases the we're having asm.js caching failures caused by initialization of the underlying storage system.  Add a separate error message (from the generic "internal error" message) for this.
Attachment #8594008 - Flags: review?(Jan.Varga)
Comment on attachment 8594008 [details] [diff] [review]
new-error-message

Review of attachment 8594008 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/asmjscache/AsmJSCache.cpp
@@ +767,1 @@
>    NS_ENSURE_SUCCESS(rv, rv);

Uhm, you want to keep the NS_ENSURE_SUCCESS too ?
Oops, nope, that can go.
Attachment #8594008 - Attachment is obsolete: true
Attachment #8594008 - Flags: review?(Jan.Varga)
Attachment #8594079 - Flags: review?(Jan.Varga)
Attachment #8594079 - Flags: review?(Jan.Varga) → review+
https://hg.mozilla.org/mozilla-central/rev/905f210de15b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: