Closed Bug 1155750 Opened 9 years ago Closed 9 years ago

Fix remaining FM jshint issues

Categories

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!
Comment on attachment 8594046 [details] [review]
[gaia] KevinGrandon:bug_1155750_fm_jshint > mozilla-b2g:master

Pin or Tim - could either of you guys give me a quick review here? This is mostly just declaring some globals and moving code around to make JSHint happy - it was complaining a lot about variables being used before definition. In the long run I suggest breaking the fm.js file up into multiple different modules, but for now I'm just trying to get these linter errors cleaned up. Thanks!
Attachment #8594046 - Flags: review?(timdream)
Attachment #8594046 - Flags: review?(pzhang)
Comment on attachment 8594046 [details] [review]
[gaia] KevinGrandon:bug_1155750_fm_jshint > mozilla-b2g:master

r=me, thanks.
Attachment #8594046 - Flags: review?(timdream)
Attachment #8594046 - Flags: review?(pzhang)
Attachment #8594046 - Flags: review+
Thank you!
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: