1155766 - Fix various bad assertions

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Like in bug 1155652, Coverity found some bad asserts (CID 1274348 1274349 1274353)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: QuotaManager.diff

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8594089 [details] [diff] [review]
QuotaManager.diff

Review of attachment 8594089 [details] [diff] [review]:
-----------------------------------------------------------------

Ordinarily I would bounce this to Jan but it's so simple it's not worth the extra time :)

Thanks!

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: nsHTMLCSSStyleSheet.diff

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: nsBidiPresUtils.diff

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 8594119 [details] [diff] [review]
nsBidiPresUtils.diff

Review of attachment 8594119 [details] [diff] [review]:
-----------------------------------------------------------------

Ouch!

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/ea910d309969
https://hg.mozilla.org/integration/fx-team/rev/2652222b92d5
https://hg.mozilla.org/integration/fx-team/rev/0352b6fb976f

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I backed out the QquotaManager patch in https://hg.mozilla.org/integration/fx-team/rev/a100719c0032 because the newly fixed assertion is asserting in osx xpcshell tests:
https://treeherder.mozilla.org/logviewer.html#?job_id=2752470&repo=fx-team

Comment 8

[Sylvestre Ledru [:Sylvestre]]

OK, either the assert is incorrect, the test(s) should be updated or their is something wrong in the code.

Jan, any idea?

Comment 9

[Jan Varga [:janv]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> OK, either the assert is incorrect, the test(s) should be updated or their
> is something wrong in the code.
> 
> Jan, any idea?

I'll take a look.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea910d309969
https://hg.mozilla.org/mozilla-central/rev/2652222b92d5

Comment 11

[Sylvestre Ledru [:Sylvestre]]

bug 1157670 has been fixed and Jan took the assert change. Closing this one then.