1155890 - feedback forms should have a link to the privacy policy

Status: RESOLVED FIXED

(Input Graveyard :: Frontend, defect, P1)

Description

[Lonnen :lonnen]

There should be a link from each of the feedback forms (https://input.mozilla.org/en-US/feedback) to the Privacy Policy, preferably in the footer of the page.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Note that this affects both the generic feedback form and the Firefox OS feedback form.

The current thank you page (e.g. https://input.mozilla.org/en-US/thanks) has a footer with the required link in it. It's sufficient to take that footer and add it to the rest of the feedback form pages. Having the same footer on all pages (actually, it's the whole site) both satisfies the need for a privacy policy link as well as makes it so that we only have to make changes in one place going forward.

Putting this bug in this quarter and grabbing it to work on next week.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I spent a bunch of time restyling the Firefox OS feedback form. Now the two forms share structure, so tossing in a footer and maintaining it over time in one central point should be pretty easy.

Working on it now.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Things to do here:

1. add footer to picker, cards in generic feedback form, cards in fxos feedback form and thank you page (it's on the thank you page already, but we might need to redo how that's implemented)

2. add a "check the privacy policy link" test to the smoketests for the generic feedback form and the fxos feedback form to verify that there is a visible privacy policy link on every card and that it goes to the correct place

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/553

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in https://github.com/mozilla/fjord/commit/84ad0735eb18c9da4b5c69c444ac84dd86798556

Pushed to production just now!

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was about 2 points.