1155896 - xpcshell log statements truncated due to equality checks for long strings

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

I saw this while working on another bug and from what I can tell it happens when there are full paths in the update log files.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Stephen, while working on a different bug I noticed that when comparing strings using Assert.equal that the string printed in the xpcshell log was truncated if the string was long due to there being a path. To fix this I've replaced the common part of the path for the tests. I also noticed that the call to checkCallbackAppLog wasn't completing on the marAppApplyUpdate* tests and that these tests shouldn't call that function since they never create a callback log since they use the app which won't create that log file. The reason it never caused a problem is due to checkCallbackAppLog using a timer to call itself over and over until the callback log is created and the callsites continuing the tests so they passed anyways.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Just noticed that debugDump was not printing out the correct caller so I added that to this patch as well.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev3

and another just noticed...

when DEBUG_AUS_TEST is true the xpcshell harness head.js outputs the following errors repeatedly
"JavaScript error: c:\\moz\\_1_mozilla-central\\mozilla\\testing\\xpcshell\\head.js, line 130: TypeError: do_print is not a function"
[10504] WARNING: Reentrancy error: some client attempted to display a message to the console while in a console listener. The following message was discarded: "[JavaScript Error: "TypeError: do_print is not a function" {file: "c:\\moz\\_1_mozilla-central\\mozilla\\testing\\xpcshell\\head.js" line: 130}]": file c:\\moz\\_1_mozilla-central\\mozilla\\xpcom\\base\\nsConsoleService.cpp, line 191

Turning off logging in nsUpdateService.js before do_test_finished and calling do_test_finished with do_execute_soon these errors are no longer printed. This is due to the logging in nsUpdateService.js using Services.console.logStringMessage and do_print no longer being defined for the the observer in xpcshell's head.js and the do_execute_soon is needed to allow nsUpdateService.js time to disable logging.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev4

better still... this fixes all of the do_print errors that are logged

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to try along with the patch from bug 1156046
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93146a44f3e0

Comment 6

[Robert Strong (they/them - no direct email)]

There are problems with the patch from bug 1156046. Push to try with just this patch
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b836124d94f1

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cfbb5cd2b27b

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cfbb5cd2b27b