1155907 - [Windows Management][Task Manager] User is able to call an app to the forground and then close it during the animation

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Description:
When the user selects an app in task manager, if they try to scroll the app during the animation of bringing the app to the foreground, the app will show full screen, and then promptly close due to it thinking that the user was trying to close the app from card view

Repro Steps:
1) Update a Flame to 20150417010203
2) Open any app
3) Long press home button to access card view
4) Tap on the app, then swipe up as it is putting its focus to the foreground


Actual:
The app goes full screen, then closes


Expected:
The app goes full screen, and cannot be closed unless the user re-enters card view and swipes up without tapping on the app

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150417010203
Gaia: 3cd0a9facce26c2acc7be3755a17131a6358e33f
Gecko: 51e3cb11a258
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 10/10
See attached: Logcat, Video - https://youtu.be/tysgAv2cMs4

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on Flame 2.2

The app goes full screen, then closes

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150417002504
Gaia: d50b8a3919a7b4d8d289f150d3b9bed704ebafa9
Gecko: 5ebf32030512
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

=========================================================================================

This issue does NOT occur on Flame 2.1

The app is quickly and smoothly transitioned to the foreground without time for interuption to close the app

Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat)(Full Flash)
Build ID: 20150415001211
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: 3e3cbe35bce3
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Peter Bylenga [:PBylenga]]

Functional regression of a core feature, app is mistakenly closed when a user wants to scroll.

Requesting a window.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

2.1 is not a legitimate comparison because card view had a re-design from 2.2 onwards. I've checked earliest b2g37 (v2.2) build that has the new card view design and issue does NOT repro there. So it is a regression since the redesign happened but it is not a regression from 2.1.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

Actually, no. After excessive trying on the earliest 2.2 build, the issue is indeed reproducible. Removing window-wanted tag because we don't have evidence to show that this had once worked after the re-design of card view.

Issue reproduces on:
Device: Flame 2.2
BuildID: 20150112081448
Gaia: b0254d13e67b0bd4c74c2f2c9b9ea1251949d9fe
Gecko: cac64af410a1
Version: 37.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 5

[Gregor Wagner [:gwagner]]

Sam, can you take a look?

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:task-manager-hide-events-bug-1155907 > mozilla-b2g:master

Comment 7

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8596203 [details] [review]
[gaia] sfoster:task-manager-hide-events-bug-1155907 > mozilla-b2g:master

From the PR: The setTimeout in exitToApp was leaving a window in which you could still interact with the card view while it transitioned to open the selected app. This patch rearranges things just a little to close up that window by immediately detaching the "showing" listeners

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8596203 [details] [review]
[gaia] sfoster:task-manager-hide-events-bug-1155907 > mozilla-b2g:master

r=me with nits on github

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/dd80f9fed5f719330c0abd556cfc32bf9eea2b31

Comment 11

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8596203 [details] [review]
[gaia] sfoster:task-manager-hide-events-bug-1155907 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Fallout from new card view implementation
[User impact] if declined: Its possible to swipe to close an app while its transitioning to open from the card view, also you can open more than one app simultaneously from card view to get into a janky and unknown/unstable state (bug 1156927). 
[Testing completed]: Added new unit test, tested on device (Flame/319MB)
[Risk to taking this patch] (and alternatives if risky): Low risk, alternative is to live with it
[String changes made]: None

Comment 12

[bhavana bajaj [:bajaj]]

We should back this out if we have *any* fallouts.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5bd4e60e0d3f99ff3be3c60d97f57ce615ccefcd

Comment 14

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v2.2&3.0.

Actual results: On card view,tap on the app and quickly swipe up as it is putting its focus to try to close app, the app will be opened and not be closed as expected.

See attachment: verified_v2.2&3.0.mp4.
Reproduce rate: 0/10

----------------------------------------------------------------
Device: Flame 2.2 build(Pass)
Build ID               20150426002504
Gaia Revision          265ca0bc9408c21fc4b25a259fcee7fb642cd06b
Gaia Date              2015-04-24 19:13:28
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1908685d798d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150426.043030
Firmware Date          Sun Apr 26 04:30:42 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 build(Pass)
Build ID               20150426160201
Gaia Revision          b4c949cdc780893897c9b45c1adea46e2eb694ff
Gaia Date              2015-04-24 16:13:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/37d60e3b8be6
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150426.193323
Firmware Date          Sun Apr 26 19:33:34 EDT 2015
Bootloader             L1TC000118D0

Comment 15

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2&3.0.mp4