Closed
Bug 1155937
Opened 9 years ago
Closed 9 years ago
Figure out whether the comments about Baseline ICs in IonBuilder::getPropTryInnerize still make sense
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: jandem)
Details
Attachments
(1 file)
|
1.72 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I'm not sure they do. We might still not have type info, but not because baseline ICs don't know about innerization.
Flags: needinfo?(jdemooij)
|
Assignee | |
Comment 1•9 years ago
|
||
Hm I think you're right, this patch removes the comment. I also moved the other comment to the top of getPropTryInnerize, somebody moved it inside the `if` and it became a bit confusing.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Flags: needinfo?(jdemooij)
Attachment #8634029 -
Flags: review?(bzbarsky)
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8634029 [details] [diff] [review] Patch r=me
Attachment #8634029 -
Flags: review?(bzbarsky) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d2f4c8ad4ed5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
|
|
||
Comment 5•9 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d2f4c8ad4ed5
status-b2g-v2.5:
--- → fixed
|
|
||
Comment 6•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•