Closed
Bug 1155988
Opened 9 years ago
Closed 9 years ago
Use the ready promise more often in service worker tests
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
12.39 KB,
patch
|
nsm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8594348 -
Flags: review?(nsm.nikhil)
Assignee | ||
Updated•9 years ago
|
Blocks: ServiceWorkers-B2G
Comment on attachment 8594348 [details] [diff] [review] Use the ready promise more often in service worker tests Review of attachment 8594348 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/test/serviceworkers/fetch/context/register.html @@ +7,2 @@ > function done(reg) { > + ok(reg.waiting || reg.active, "Either active or waiting worker should be available."); if ready resolved, only reg.active should be non-null in this case. ::: dom/workers/test/serviceworkers/fetch/https/clonedresponse/register.html @@ +7,2 @@ > function done(reg) { > + ok(reg.waiting || reg.active, "Either active or waiting worker should be available."); ditto. ::: dom/workers/test/serviceworkers/fetch/https/register.html @@ +7,2 @@ > function done(reg) { > + ok(reg.waiting || reg.active, "Either active or waiting worker should be available."); here too ::: dom/workers/test/serviceworkers/fetch/sandbox/register.html @@ +7,2 @@ > function done(reg) { > + ok(reg.waiting || reg.active, "Either active or waiting worker should be available."); same here.
Attachment #8594348 -
Flags: review?(nsm.nikhil) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fe30eb26b6ab
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•