Dump the rejection of the promise returned by ServiceWorkerRegistration.unregister() in our tests

RESOLVED FIXED in Firefox 40

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8594350 [details] [diff] [review]
Dump the rejection of the promise returned by ServiceWorkerRegistration.unregister() in our tests
Attachment #8594350 - Flags: review?(nsm.nikhil)
(Assignee)

Updated

3 years ago
Blocks: 1131322
(Assignee)

Updated

3 years ago
Blocks: 1112469
Comment on attachment 8594350 [details] [diff] [review]
Dump the rejection of the promise returned by ServiceWorkerRegistration.unregister() in our tests

Review of attachment 8594350 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/test_close.html
@@ +43,3 @@
>              SimpleTest.finish();
> +          }, function(e) {
> +            dump("Unregistering the SW failed with " + e + "\n");

SimpleTest.finish()

::: dom/workers/test/serviceworkers/test_empty_serviceworker.html
@@ +26,5 @@
>      registration.unregister().then(function(success) {
>        ok(success, "unregister worked");
>        SimpleTest.finish();
> +    }, function(e) {
> +      dump("Unregistering the SW failed with " + e + "\n");

finish here too.

::: dom/workers/test/serviceworkers/test_serviceworker_interfaces.html
@@ +20,5 @@
>            ok(success, "The service worker should be unregistered successfully");
>  
>            SimpleTest.finish();
> +        }, function(e) {
> +          dump("Unregistering the SW failed with " + e + "\n");

and here

::: dom/workers/test/serviceworkers/test_serviceworker_not_sharedworker.html
@@ +41,5 @@
>            registration.unregister().then(function(success) {
>              ok(success, "unregister should succeed");
>              SimpleTest.finish();
> +          }, function(e) {
> +            dump("Unregistering the SW failed with " + e + "\n");

and here.
Attachment #8594350 - Flags: review?(nsm.nikhil) → review+
https://hg.mozilla.org/mozilla-central/rev/df337fdbcc2d
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.