1156021 - text-indent with percentage value in vertical writing-modes

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Gérard Talbot]

Tests (with vendor-prefixes)
----------------------------

A)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vrl-006.xht

B)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vlr-007.xht

C)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vrl-008.xht

D)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vlr-009.xht


Expected results
----------------

A)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s71-abs-pos-non-replaced-vlr-009-ref.xht

B)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vlr-003-ref.xht

C)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vrl-008-ref.xht

D)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vlr-005-ref.xht


Explanation
-----------
'text-indent' set with a percentage unit on an element must be a percentage of its containing block height (measure or logical width).
'text-indent' computed and used value (specified with a percentage unit) must be calculated with respect to the measure (logical width) of the containing block.


Notes
-----
- Those tests (along with 12 other text-indent tests currently being developed) will eventually be submitted to the test.csswg.org repository 
- Chrome 44.0.2369.0 dev pass these 4 tests. IE11 passes the 'direction: ltr' tests (006 and 007) but fails the 'direction: rtl' tests (008 and 009). Prince 9.0.5 passes the 2 vertical-rl tests (006 and 008).
- I am using Firefox 40.0a1 buildID=20150417134120
- I use Linux 3.16.0-34-generic x86_64, Qt: 4.8.6, KDE 4.14.1; Kubuntu (utopic) 14.10
- I've searched for duplicates and did not find any.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The code in nsBlockFrame::Reflow looks fine, so I think it's probably just the code in nsLineLayout::BeginLineReflow that's calling nsHTMLReflowState::GetContainingBlockContentWidth.

Comment 2

[Gérard Talbot]

The used text-indent value in all those 4 tests should be 80px. 

In Firefox 40.0a1 buildID=20150417134120, it is 40px.

Comment 3

[Gérard Talbot]

Non-orthogonal tests (with vendor-prefixes)
-------------------------------------------

E)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vrl-014.xht

F)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vlr-015.xht

G)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vrl-016.xht

H)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vlr-017.xht


Expected results
----------------

E)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vrl-010-ref.xht

F)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vlr-011-ref.xht

G)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vrl-012-ref.xht

H)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s74-text-indent-vlr-013-ref.xht

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Use containing block inline-size (as appropriate for writing mode) to compute text-indent when specified as percentage

As noted in comment 1, we just need to check the writing mode and get the right dimension from the containing block to use as the basis for percentages. With this patch, all the testcases in comment 0 and comment 3 look good.

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Reftest for text-indent specified as percent in vertical writing mode

And a reftest to go with it.

Comment 6

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b895b83ba2cc

Comment 7

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3b7f39745b
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb6a787276ec

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9f3b7f39745b
https://hg.mozilla.org/mozilla-central/rev/fb6a787276ec