1156028 - Teach clang-analyzer about XPCOM assertion macros

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[(no longer active)]

Attachment: Teach clang-analyzer about XPCOM assertion macros

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Seems to work. It changed the number of warnings found by scan-build from 1502 to 1452

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Mostly impacting
"Dereference of null pointer" but also "Argument with 'nonnull' attribute passed null", "Called C++ object pointer is null" & "Result of operation is garbage or undefined"

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8594412 [details] [diff] [review]
Teach clang-analyzer about XPCOM assertion macros

Review of attachment 8594412 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsImageFrame.cpp
@@ +2225,1 @@
>      if (NS_ConvertASCIItoUTF16(kIconLoadPrefs[i]) == nsDependentString(aData))

I wonder if it'd be worth making kIconLoadPrefs char16_t* so we avoid this conversion, even under DEBUG?

Comment 6

[(no longer active)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #3)
> Seems to work. It changed the number of warnings found by scan-build from
> 1502 to 1452

Yes, I know.  :-)  I was using it over the weekend.  Also see bug 1156029.

Comment 7

[(no longer active)]

(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #5)
> Comment on attachment 8594412 [details] [diff] [review]
> Teach clang-analyzer about XPCOM assertion macros
> 
> Review of attachment 8594412 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: layout/generic/nsImageFrame.cpp
> @@ +2225,1 @@
> >      if (NS_ConvertASCIItoUTF16(kIconLoadPrefs[i]) == nsDependentString(aData))
> 
> I wonder if it'd be worth making kIconLoadPrefs char16_t* so we avoid this
> conversion, even under DEBUG?

Then we'd need to convert them to UTF-8 again before passing it to the Preferences API.  Doesn't sound worth it.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbd5e3eb47d1

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dbd5e3eb47d1