Closed Bug 1156030 Opened 8 years ago Closed 8 years ago

Remove some obsolete static assertion macros from the tree

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8594415 [details] [diff] [review]
Remove some obsolete static assertion macros from the tree

Review of attachment 8594415 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/test/testplugin/nptest.cpp
@@ +303,5 @@
>    echoString,
>  };
>  
> +static_assert(ARRAY_LENGTH(sPluginMethodIdentifierNames) ==
> +              ARRAY_LENGTH(sPluginMethodFunctions),

Could you remove ARRAY_LENGTH in favor of #include "mozilla/ArrayUtils.h" MOZ_ARRAY_LENGTH too, while you're removing duplicative junk?
Attachment #8594415 - Flags: review?(jwalden+bmo) → review+
Yeah but I'll do it in a separate bug.
https://hg.mozilla.org/mozilla-central/rev/fefff614bc04
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Depends on: 1162310
You need to log in before you can comment on or make changes to this bug.