Closed Bug 1156089 Opened 9 years ago Closed 9 years ago

Fix remaining fl jshint issues

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Gallery
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

[gaia] KevinGrandon:bug_1156089_fl_jshint > mozilla-b2g:master
46 bytes, text/x-github-pull-request
djf
: review+
Details | Review 
We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!
Comment on attachment 8594524 [details] [review]
[gaia] KevinGrandon:bug_1156089_fl_jshint > mozilla-b2g:master

David - Can you take a look at or redirect this when you get a chance? Just fixing the last remaining jshint issues here. Thanks!
Attachment #8594524 - Flags: review?(dflanagan)
Comment on attachment 8594524 [details] [review]
[gaia] KevinGrandon:bug_1156089_fl_jshint > mozilla-b2g:master

Looks good. Thanks for doing this, Kevin, and sorry the review took so long.
Attachment #8594524 - Flags: review?(dflanagan) → review+
No worries, thank you for the review! I've responded to your comment on github, happy to restructure following the landing if you would like to do so.
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Oops, we have no forward lock component, but since you are a peer of gallery, and this was essentially implemented for media - I'm going to cheat and move this to the gallery component.
Component: Gaia::FMRadio → Gaia::Gallery
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: