1156132 - (about:preferences) in-content preferences tab favicon frequently missing

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[mcdavis941 (sporadically reading bugmail)]

With Fx38beta:

The favicon of about:preferences / in-content preferences is frequently missing.  

This seems associated with having about:preferences already open in a tab on browser restart, with the selected about:preferences view as something other than "General" ("Advanced" for example), after which the favicon goes missing when loading that tab's contents.  

The favicon seems correctly set when restarting with "General" as the selected category.  

It's also correct whenever you open a new tab with about:preferences in it (as opposed to reloading in an existing tab).  

STR:
1 - Fx38beta, fresh profile default theme
2 - make sure in-content preferences enabled in about:config
3 - open about:preferences
4 - in about:preferences, select category "Advanced" (anything other than "General")
5 - restart the browser, leaving about:preferences open in a tab
6 - note missing favicon for about:preferences

I believe I'm on fx38beta4 (I want to finish the work I'm doing with what I have now before upgrading to a newer beta) so there's a chance this bug is already fixed in a newer beta.

Comment 1

[u428464]

It also happens when opening Preferences by clicking "Sign in to Sync" in the menu panel.

Comment 2

[:Gijs (he/him)]

(In reply to Guillaume C. [:ge3k0s] from comment #1)
> It also happens when opening Preferences by clicking "Sign in to Sync" in
> the menu panel.

Can you reproduce on Nightly? I think this is a dupe of bug 519028 which was recently fixed.

Comment 3

[u428464]

(In reply to :Gijs Kruitbosch from comment #2)
> (In reply to Guillaume C. [:ge3k0s] from comment #1)
> > It also happens when opening Preferences by clicking "Sign in to Sync" in
> > the menu panel.
> 
> Can you reproduce on Nightly? I think this is a dupe of bug 519028 which was
> recently fixed.

In fact I tested this a few hours ago because I saw that bug 519028 was fixed, but the issue remains on latest Nightly.

Comment 4

[:Gijs (he/him)]

(In reply to Guillaume C. [:ge3k0s] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > (In reply to Guillaume C. [:ge3k0s] from comment #1)
> > > It also happens when opening Preferences by clicking "Sign in to Sync" in
> > > the menu panel.
> > 
> > Can you reproduce on Nightly? I think this is a dupe of bug 519028 which was
> > recently fixed.
> 
> In fact I tested this a few hours ago because I saw that bug 519028 was
> fixed, but the issue remains on latest Nightly.

I can't reproduce the 'sign in to sync' preferences favicon bustage on nightly on OS X, at least.

Can you doublecheck in a clean profile, or see if there are any other factors that might explain the difference, like add-ons or something?

Comment 5

[u428464]

(In reply to :Gijs Kruitbosch from comment #4)
> (In reply to Guillaume C. [:ge3k0s] from comment #3)
> > (In reply to :Gijs Kruitbosch from comment #2)
> > > (In reply to Guillaume C. [:ge3k0s] from comment #1)
> > > > It also happens when opening Preferences by clicking "Sign in to Sync" in
> > > > the menu panel.
> > > 
> > > Can you reproduce on Nightly? I think this is a dupe of bug 519028 which was
> > > recently fixed.
> > 
> > In fact I tested this a few hours ago because I saw that bug 519028 was
> > fixed, but the issue remains on latest Nightly.
> 
> I can't reproduce the 'sign in to sync' preferences favicon bustage on
> nightly on OS X, at least.
> 
> Can you doublecheck in a clean profile, or see if there are any other
> factors that might explain the difference, like add-ons or something?

I can still reproduce but I've only tried on Windows with Adblock plus installed.

Comment 6

[u428464]

This issue seems to be fixed in Firefox 47.

Comment 7

[:Gijs (he/him)]

Good spot, fixed by bug 408415.

Comment 8

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #7)
> Good spot, fixed by bug 408415.

oh, hm, though the earlier comments say it wasn't. Let's just resolve WFM, then, I guess? :-\

Comment 9

[u428464]

Yes my bad. I must have done something wrong in my previous testing.