1156140 - Choose different code path for boot animation based on device capability

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Chiajung Hung [:chiajung]]

Attachment: v1

In bug 1032180, I proposed a method to show boot animation on devices without hwc, however, that makes boot animation stops earlier than needed on devices with hwc(e.g., Flame).

In this bug, I want to make different devices run different pathes to get boot animation on both device and stop the animation as late as possible for hwc-compatible device.

Comment 1

[Vincent Liu[:vliu]]

LGTM. Thanks for your great help.

Comment 2

[Chiajung Hung [:chiajung]]

Comment on attachment 8594574 [details] [diff] [review]
v1

@Michael Wu,
Can you help review this? We will search for better animation stop point in bug 1156141 base on this. Per talk last time, hwc-compatible device should need a better stop point only w/ this patch. fb only device should need more trick, which should be a follow up for bug 1156141 or something like bug 1055457.

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 8594574 [details] [diff] [review]
v1

Review of attachment 8594574 [details] [diff] [review]:
-----------------------------------------------------------------

The approach here looks good, and we can pass the animation buffer to gecko later if we want to extend the length of the animation. Good stuff - just have to polish the patch. Sotaro also probably bitrotted you a bit in bug 1152370.

The indentation in this patch is inconsistent - please use 4 spaces.

::: widget/gonk/libdisplay/GonkDisplayJB.cpp
@@ +132,5 @@
> +
> +    uint32_t usage = GRALLOC_USAGE_HW_FB | GRALLOC_USAGE_HW_RENDER | GRALLOC_USAGE_HW_COMPOSER;
> +    if (mFBDevice) {
> +        // If device uses fb, they can not use single buffer for boot animation
> +        mBootAnimBuffer = nullptr;

No need to set it to null - it defaults to null.

@@ +167,4 @@
>  ANativeWindow*
>  GonkDisplayJB::GetNativeWindow()
>  {
> +    if (mBootAnimBuffer.get() == nullptr) {

if (!mBootAnimBuffer.get()) {

@@ +235,4 @@
>  bool
>  GonkDisplayJB::SwapBuffers(EGLDisplay dpy, EGLSurface sur)
>  {
> +    if (mBootAnimBuffer.get() != nullptr) {

if (mBootAnimBuffer.get()) {

@@ +333,5 @@
>  GonkDisplayJB::QueueBuffer(ANativeWindowBuffer* buf)
>  {
>      bool success = Post(buf->handle, -1);
> +    int error = 0;
> +    if (mFBDevice) {

Checking mBootAnimBuffer would be more consistent.

@@ +342,5 @@
>  
>  void
>  GonkDisplayJB::UpdateFBSurface(EGLDisplay dpy, EGLSurface sur)
>  {
> +    if (mBootAnimBuffer.get() != nullptr) {

if (mBootAnimBuffer.get()) {

Comment 4

[Chiajung Hung [:chiajung]]

Attachment: v2

Rebase, fix indent, fix coding style.

Comment 5

[Chiajung Hung [:chiajung]]

Try result:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=21f9e865821c

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/235ce90dd2d8

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/235ce90dd2d8