If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Stingray][Home] Allow user to move cards out of a folder

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::Home
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: yifan, Assigned: yifan)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1117699 +++

In edit mode, allow user to move cards out of a folder to the main list.
This is a follow-up bug from bug 1117699.
(Assignee)

Updated

2 years ago
Depends on: 1158665
(Assignee)

Updated

2 years ago
Assignee: nobody → yliao
(Assignee)

Comment 1

2 years ago
Created attachment 8600808 [details] [review]
review only patch

Hi Rex, please help review these 3 commits for dragging a card out of a folder. Thanks!
Attachment #8600808 - Flags: review?(rexboy)
Comment on attachment 8600808 [details] [review]
review only patch

Looks good to me with some comments. Please make modify on them, squash commits and modify commit messages before landing.
If you have questions on comments just talk to me. Thanks!
Attachment #8600808 - Flags: review?(rexboy) → review+

Comment 3

2 years ago
Created attachment 8601304 [details] [review]
[gaia] begeeben:1156143_allow_user_to_move_cards_out_of > mozilla-b2g:master
(Assignee)

Comment 4

2 years ago
Comment on attachment 8601304 [details] [review]
[gaia] begeeben:1156143_allow_user_to_move_cards_out_of > mozilla-b2g:master

Thanks for the review! Here is the modified pull request. Please see if there's refinements needed.
Attachment #8601304 - Flags: review?(rexboy)
Comment on attachment 8601304 [details] [review]
[gaia] begeeben:1156143_allow_user_to_move_cards_out_of > mozilla-b2g:master

Still two places before landing. Ping me if you are uncertain on my comments.
Attachment #8601304 - Flags: review?(rexboy) → review+
(Assignee)

Updated

2 years ago
Blocks: 1161990
(Assignee)

Comment 6

2 years ago
Thanks for the review! Merged into master:

https://github.com/mozilla-b2g/gaia/pull/29877
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]

Updated

2 years ago
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices]
You need to log in before you can comment on or make changes to this bug.