1156153 - Blocker for successful test build on a Puppet configured 2008 slave

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Comment 1

[Mark Cornmesser [:markco]]

Attachment: BUG1156486.patch

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8604180 [details] [diff] [review]
BUG1156486.patch

Review of attachment 8604180 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with $p removed

::: modules/packages/manifests/git.pp
@@ +5,5 @@
> +    
> +    file {
> +        "C:/installersource/puppetagain.pub.build.mozilla.org/EXEs/Git-1.9.2-preview20140411.exe":
> +            ensure  => file,
> +            source  => "puppet:///repos$p/EXEs/Git-1.9.2-preview20140411.exe",

$p is undefined here

Comment 3

[Mark Cornmesser [:markco]]

Comment on attachment 8604180 [details] [diff] [review]
BUG1156486.patch

$p removed from the git.pp.

 https://hg.mozilla.org/build/puppet/rev/e7c1e98a46e5

Comment 4

[Mark Cornmesser [:markco]]

Attachment: BUG1156153-2.patch

Comment 5

[Mark Cornmesser [:markco]]

Comment on attachment 8604846 [details] [diff] [review]
BUG1156153-2.patch

Review of attachment 8604846 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/puppet/rev/5b6fc64bc41a