Closed
Bug 1156188
Opened 9 years ago
Closed 9 years ago
[Stingray][TvDeck] Use asyncStorage instead of localStorage for storing last TV settings.
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: suchiu, Assigned: suchiu)
References
Details
Attachments
(1 file)
LocalStorage is used to store last (tuner, source, channel) tuples. However, using non-blocking asyncStorage is a better way to do it.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8595279 [details] [review] [gaia] sean2449:Bug_1156188-asyncStorage > mozilla-b2g:master 1. Change localStorage to asyncStorage. 2. fetchSettingsFromHash returns a promise in order to handle asyncStorage.
Attachment #8595279 -
Flags: review?(im)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8595279 [details] [review] [gaia] sean2449:Bug_1156188-asyncStorage > mozilla-b2g:master looks good to me.
Attachment #8595279 -
Flags: review?(im) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•9 years ago
|
||
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
|
|
Assignee | |
Updated•9 years ago
|
Component: Gaia → Gaia::TV
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•9 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#tU8tHn2TTaO34G213E3Xqw The pull request failed to pass integration tests. It could not be landed, please try again.
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•9 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#s2yF7KY0SJCEBseSDYAHjg The pull request failed to pass integration tests. It could not be landed, please try again.
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•9 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#-6cduB0jS06ojjkhWDU6JQ The pull request failed to pass integration tests. It could not be landed, please try again.
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 8•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/ec0bd01c224544ef8fa134122dd36437b10464d7
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•