Closed Bug 1156201 Opened 5 years ago Closed 5 years ago

When rejoining a conversation as a link clicker in a session where a window is shared, the local and remote video layout are wrong

Categories

(Hello (Loop) :: Client, defect, P2)

defect
Points:
2

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Iteration:
40.2 - 27 Apr
Tracking Status
firefox40 --- fixed

People

(Reporter: RT, Assigned: standard8)

Details

(Whiteboard: [sharing])

Attachments

(3 files)

Attached image Sans titre.png
Environment: Link clicker on Windows 8 using Firefox or Chrome

STR:
1 Join a conversation where window sharing is already initiated
2 Leave the conversation
3 Join the conversation
4 Observe that the local cam view and remote cam view layouts are wrong (per attachment)
RT, what happens when you resize the window? What is the contents of your browser console?
Flags: needinfo?(rtestard)
I'm pretty sure I was aware of this before and forgot about it. We're not resetting the dimensions cache when we leave the room. As a result, we can get some stale data in the cache which causes us not to reset the layout when we re-join the room.

Resetting the cache seems to fix it. Mike, if this looks reasonable I'll add a test and check to see if we need to add this in for some of our other code (I think we get away with it for now though).
Attachment #8594669 - Flags: feedback?(mdeboer)
Comment on attachment 8594669 [details] [diff] [review]
WIP Reset the dimensions cache

Review of attachment 8594669 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8594669 - Flags: feedback?(mdeboer) → feedback+
Resetting the window fixes the layout.
Clearing NI since you guys seem to have fixed it already :)
Flags: needinfo?(rtestard)
(In reply to Romain Testard [:RT] from comment #4)
> Resetting the window fixes the layout.
> Clearing NI since you guys seem to have fixed it already :)

Well, not really, but now we now how to fix it ;)
Comment on attachment 8595911 [details] [diff] [review]
Reset the video dimensions cache when in initial room states to avoid issues with not correctly displaying video streams when a room is re-entered.

Review of attachment 8595911 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!
Attachment #8595911 - Flags: review?(mdeboer) → review+
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Rank: 25
Flags: firefox-backlog+
Priority: -- → P2
Whiteboard: [sharing]
https://hg.mozilla.org/integration/fx-team/rev/5e4ea8c83c51
Iteration: --- → 40.2 - 27 Apr
Points: --- → 2
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/5e4ea8c83c51
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.