1156201 - When rejoining a conversation as a link clicker in a session where a window is shared, the local and remote video layout are wrong

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Romain Testard [:RT]]

Attachment: Sans titre.png

Environment: Link clicker on Windows 8 using Firefox or Chrome

STR:
1 Join a conversation where window sharing is already initiated
2 Leave the conversation
3 Join the conversation
4 Observe that the local cam view and remote cam view layouts are wrong (per attachment)

Comment 1

[Mike de Boer [:mikedeboer]]

RT, what happens when you resize the window? What is the contents of your browser console?

Comment 2

[Mark Banner (:standard8)]

Attachment: WIP Reset the dimensions cache

I'm pretty sure I was aware of this before and forgot about it. We're not resetting the dimensions cache when we leave the room. As a result, we can get some stale data in the cache which causes us not to reset the layout when we re-join the room.

Resetting the cache seems to fix it. Mike, if this looks reasonable I'll add a test and check to see if we need to add this in for some of our other code (I think we get away with it for now though).

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8594669 [details] [diff] [review]
WIP Reset the dimensions cache

Review of attachment 8594669 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 4

[Romain Testard [:RT]]

Resetting the window fixes the layout.
Clearing NI since you guys seem to have fixed it already :)

Comment 5

[Mike de Boer [:mikedeboer]]

(In reply to Romain Testard [:RT] from comment #4)
> Resetting the window fixes the layout.
> Clearing NI since you guys seem to have fixed it already :)

Well, not really, but now we now how to fix it ;)

Comment 6

[Mike de Boer [:mikedeboer]]

*know

Comment 7

[Mark Banner (:standard8)]

Attachment: Reset the video dimensions cache when in initial room states to avoid issues with not correctly displaying video streams when a room is re-entered.

Comment 8

[Mike de Boer [:mikedeboer]]

Comment on attachment 8595911 [details] [diff] [review]
Reset the video dimensions cache when in initial room states to avoid issues with not correctly displaying video streams when a room is re-entered.

Review of attachment 8595911 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!

Comment 9

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/5e4ea8c83c51

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e4ea8c83c51