1156202 - [Stingray] Unable to unpin card within folder

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Description

[Tzu-Lin Huang [:dwi2][:tzhuang]]

We are unable to unpin card which resides in folder. This is because 'CardManager.removeCard()' did not search card within folder.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] dwi2:bug1156202 > mozilla-b2g:master

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8595110 [details] [review]
[gaia] dwi2:bug1156202 > mozilla-b2g:master

Hi John,

Because Rex is away until 4/27, I'll have to ask for your review for the patch.
Thanks.

This patch is based on the patch of bug 1155032. I'll rebase to master once bug 1155032 was landed.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8595110 [details] [review]
[gaia] dwi2:bug1156202 > mozilla-b2g:master

Sorry, I totally don't know how to test it. I think we should let yifan to make this decision.

Comment 4

[yifan [:yifan][:yliao]]

Comment on attachment 8595110 [details] [review]
[gaia] dwi2:bug1156202 > mozilla-b2g:master

Could you please review this Rex? Thanks!

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8595110 [details] [review]
[gaia] dwi2:bug1156202 > mozilla-b2g:master

r=me but see my comments on Github.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Thanks. All comments are addressed and waiting for Gaia-try result:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8ea61bbaa4c862ef0ca4a270db4b12953c25e6ab

Comment 7

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#j-51ms1rSsGv9OuSk1rtiw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/bd638f8ad62f5a6d7fd2e6f7943c5c8baf7b7fc8