1156240 - Return proper "See Also" data on REST API call to a bug

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Marcus von Appen]

Attachment: rest_seealso.diff

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20150402191859

Steps to reproduce:

Query a bug via REST, which has one or more "See Also" URLs configured (e.g. localhost:8080/rest/bug/1)




Actual results:

The JSON result will look like 
...
  "see_also" : [
       "Bugzilla::BugUrl::ARRAY(0x12345)"
  ],


Expected results:

A proper URL should have been returned (find a fix attached).

Comment 1

[David Lawrence [:dkl]]

Comment on attachment 8594710 [details] [diff] [review]
rest_seealso.diff

Review of attachment 8594710 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 2

[Marcus von Appen]

I do not see the point of moving that change to release 6.0.

The see_also value is unusable in 5.0+ at the moment, so it does not provide any useful value and thus does not break any compatibility.

Comment 3

[Marcus von Appen]

And while here, I wonder, why I became the assignee - I can't fix the bug, since I do not have commit access to the repo and thus cannot fix the issue. What is the intended bug workflow here?

Comment 4

[David Lawrence [:dkl]]

(In reply to mva from comment #2)
> I do not see the point of moving that change to release 6.0.
> 
> The see_also value is unusable in 5.0+ at the moment, so it does not provide
> any useful value and thus does not break any compatibility.

It is only broken in 5.1 and above so it will be in the next release (probably 6.0). 5.0 does not have the refactored WebService API that was recently checked into trunk so it doesn't have this regression.

(In reply to mva from comment #3)
> And while here, I wonder, why I became the assignee - I can't fix the bug,
> since I do not have commit access to the repo and thus cannot fix the issue.
> What is the intended bug workflow here?

You are set to the assignee since you submitted a patch for review. When we check it in (probably me as the reviewer) the commit will get you set as the author of the patch in the git repo.

dkl

Comment 5

[David Lawrence [:dkl]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   1f981e1..6f88fd0  master -> master

Comment 6

[Ed Morley [:emorley]]

mva - thank you for the patch! :-)