1156268 - Tabs are not restored after guest session

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Flaviu Cos]

Environment: 
Device: Asus Transformer Tab (Android 4.2.1);
Build: Nightly 40.0a1 (2015-04-19);

Steps to reproduce:
1. Launch Fennec;
2. Load a few pages in different tabs;
3. Tap on Menu -> Tools -> New Guest Session;
4. Tap on Menu -> Tools -> Exit Guest Session;
5. Verify that the tabs opened at step 2 are restored.

Expected result:
The tabs opened in step 2 are correctly restored.

Actual result:
None of the tabs from step 2 are restored; Only the about:home tab is displayed. 

Regression window:
Last good build: 2015-04-18;
First Bad build: 2015-04-19;
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8af644c9b616&tochange=a32e3b93c8d8

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I see bug 1152308 in the range and it seems to be rewriting the restart code.

Flaviu - can you test mozilla-inbound before/after that bug landed?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

From IRC,

[10:30:23] snorp: oh
[10:30:29] snorp: or we're missing the didRestart intent extra
[10:30:31] snorp: that seems most likely

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Put the 'didRestart' Intent extra in when restarting

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2798bdbedfb7

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2798bdbedfb7

Comment 6

[Flaviu Cos]

Verified as fixed in build 40.0a1 2015-04-22;
Device: Asus Transformer Tab (Android 4.2.1);