1156361 - Telemetry redesign: Consolidate date & string utility functions in TelemetryUtils.jsm

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Georg Fritzsche [:gfritzsche]]

Per: https://docs.google.com/document/d/1lKRfNl5aJ0W2flOp67Y5O3WDz2dSSz7a6r23DQ89poU/edit?pli=1

Comment 1

[Georg Fritzsche [:gfritzsche]]

Bug 1140037 started consolidating some things in TelemetryUtils.jsm.

Comment 2

[Alessio Placitelli [:Dexter]]

It looks like there's not much left to be done:

- function toLocalTimeISOString(date): only used in TelemetrySession.jsm [1]
- function getLocale(): can be removed, it's not used by TelemetrySession anymore [2]
- function getMsSinceProcessStart(): used by TelemetrySession and potentially by TelemetryLog.jsm [3]
- function tomorrow(date): can be removed from TelemetrySend, no longer used [4]
- function limitStringToLength(aString, aMaxLength): used by TelemetryEnvironment [5]

[1] - https://dxr.mozilla.org/mozilla-central/rev/6adc822f5e27a55551faeb6c47a9bd8b0859a23b/toolkit/components/telemetry/TelemetrySession.jsm#1014-1015
[2] - https://dxr.mozilla.org/mozilla-central/rev/6adc822f5e27a55551faeb6c47a9bd8b0859a23b/toolkit/components/telemetry/TelemetrySession.jsm#108
[3] - https://dxr.mozilla.org/mozilla-central/rev/6adc822f5e27a55551faeb6c47a9bd8b0859a23b/toolkit/components/telemetry/TelemetryLog.jsm#18
[4] - https://dxr.mozilla.org/mozilla-central/rev/6adc822f5e27a55551faeb6c47a9bd8b0859a23b/toolkit/components/telemetry/TelemetrySend.jsm#129
[5] - https://dxr.mozilla.org/mozilla-central/search?q=limitStringToLength&redirect=false&case=true

Comment 3

[Alessio Placitelli [:Dexter]]

Georg, what do you think about moving these to TelemetryUtils:

- toLocalTimeISOString
- getMsSinceProcessStart
- limitStringToLength

And removing the others? Anything else you can think of?

Comment 4

[Georg Fritzsche [:gfritzsche]]

(In reply to Alessio Placitelli [:Dexter] from comment #3)
> Georg, what do you think about moving these to TelemetryUtils:
> 
> - toLocalTimeISOString
> - getMsSinceProcessStart
> - limitStringToLength
> 
> And removing the others? Anything else you can think of?

Definitely toLocalTimeISOString(), the other two are trivial local helpers so i'd only share them if we use them in multiple locations.
There are no other i can think of right now without searching.

Comment 5

[Alessio Placitelli [:Dexter]]

Attachment: bug1156361.patch

Comment 6

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5624b68b0890

Comment 7

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/fx-team/rev/64ad199ede21c4ab89e4b65b5b62351a3bbe5a45
Bug 1156361 - Telemetry redesign: Consolidate date & string utility functions in TelemetryUtils.jsm. r=gfritzsche

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/64ad199ede21