Closed Bug 1156384 Opened 5 years ago Closed 5 years ago

[Bugzilla Lite] Visual Polish Followup

Categories

(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect, P1)

x86
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: epang, Assigned: daleharvey)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

This is a follow up to bug 1154746 that covers remaining minor visual issues.

Dale, in the attached I've bolded items that still need to be worked on and italicized anything that's been completed.  Let me know if you have any questions!

Thanks!
1> Missing (x) clear button. Applies to password box as well. See mock

3> Blue underline. Are we able to have the underline animation seen in web components. The line expands from the center when pressed.

These will come from switching to gaia-components, I dont think its worth reimplementing prior to that: https://bugzilla.mozilla.org/show_bug.cgi?id=1141857


>  Should be the same size as dialog box (in previous screen)

We should not have a fixed size dialog, it should be the size of the text with a padding so we can handle l10n changes.


> Update 'OK' to 'Ok'

We use OK consistently throughout the OS, http://mxr.mozilla.org/gaia/search?string=Ok&find=\.properties&findi=\.css&filter=^[^\0]*%24&hitlimit=&tree=gaia

> Same style and size as Submitting bug dialogue box.

This is currently handed by the system and has system styling, this is guaranteed to be consistent with the rest of the OS and when system updates the styling of the dialogs they will be done so for everyone. I think we should also move the error alert to also use 'alert()' for consistencies sake
Hey Eric, sorry I think I forgot theres was more than one page on the previous pdf. 

Implementing most of these, a few I am not sure are right and these a few that will happen during system updates across the OS and so arent actionable just working on bzlite. Just checking those sound good with you.
Flags: needinfo?(epang)
(In reply to Dale Harvey (:daleharvey) from comment #1)
> 1> Missing (x) clear button. Applies to password box as well. See mock
> 
> 3> Blue underline. Are we able to have the underline animation seen in web
> components. The line expands from the center when pressed.
> 
> These will come from switching to gaia-components, I dont think its worth
> reimplementing prior to that:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1141857

This works for me, as long as it updates when the switch happens

> 
> 
> >  Should be the same size as dialog box (in previous screen)
> 
> We should not have a fixed size dialog, it should be the size of the text
> with a padding so we can handle l10n changes.

The dialog box can be flexible vertically for l10n but can we update the width so it's consistent with other elements such as input boxes?

> 
> 
> > Update 'OK' to 'Ok'
> 
> We use OK consistently throughout the OS,
> http://mxr.mozilla.org/gaia/search?string=Ok&find=\.properties&findi=\.
> css&filter=^[^\0]*%24&hitlimit=&tree=gaia

Works for me!
> 
> > Same style and size as Submitting bug dialogue box.
> 
> This is currently handed by the system and has system styling, this is
> guaranteed to be consistent with the rest of the OS and when system updates
> the styling of the dialogs they will be done so for everyone. I think we
> should also move the error alert to also use 'alert()' for consistencies sake

This is fine as long as it updates when the system update takes place.  Moving the alert to use the 'alert()' makes sense.
Flags: needinfo?(epang)
(In reply to Dale Harvey (:daleharvey) from comment #2)
> Hey Eric, sorry I think I forgot theres was more than one page on the
> previous pdf. 
> 
> Implementing most of these, a few I am not sure are right and these a few
> that will happen during system updates across the OS and so arent actionable
> just working on bzlite. Just checking those sound good with you.

Thanks Dale!  Had a feeling that was the reason, I should have mentioned the other pages.  Let me know if you come across any other questions :).
Awesome, Fixed in https://github.com/mozilla-b2g/bzlite/commit/307b264e81d71407c9408813de6d1347c82116ff

I think I got them all this time but again if there is something that doesnt fit then can open a bug for it, cheers
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1134701
No longer blocks: spark
Priority: -- → P1
Whiteboard: [lightsaber] → [spark]
You need to log in before you can comment on or make changes to this bug.