1156439 - [Email] Fix remaining jshint issues

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Kevin Grandon :kgrandon]

We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1156439_email_remaining_jshint > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8594925 [details] [review]
[gaia] KevinGrandon:bug_1156439_email_remaining_jshint > mozilla-b2g:master

James - could you give this a review if you have a minute?

The only spot I'm a bit concerned about is the is the change in test/config.js. I assume that this is only loaded within a window, so I should hope the change is ok. Without it, jshint throws a scoping error.

Thanks!

Comment 3

[James Burke [:jrburke]]

Comment on attachment 8594925 [details] [review]
[gaia] KevinGrandon:bug_1156439_email_remaining_jshint > mozilla-b2g:master

There are some nits (and one necessary change) mentioned in the pull request. With those addressed, r+. 

I ran the unit tests and marionette tests locally to confirm. We have some issues with a couple failing marionette tests, but they seem to be unrelated to this change, just some upkeep to do on the tests (not an issue for automation since email marionette tests are disabled for that).

Comment 4

[Kevin Grandon :kgrandon]

Thank you for the quick review. E-mail is now jshint happy :)

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/e62169edf3010cce33bac5df48aa8a9c241ce736