1156465 - Searching for <3-char strings returns all lines

Status: RESOLVED WONTFIX

(Webtools Graveyard :: DXR, defect)

Description

[Erik Rose [:erik][:erikrose]]

(This bug is for the es branch.)

Hitting Return to force a search for a shorter string than 3 chars causes all lines in the project to be returned. That's not useful. Since we can't do such a search with our trigram indexing, let's just refuse to do the search altogether, mirroring our AJAX search behavior when 2 chars are entered (which shows a bubble explaining that at least 3 chars are required to do a search).

Comment 1

[Peter Elmers [:new_one]]

Can't reproduce any more, did we fix this in https://github.com/mozilla/dxr/pull/422?

Comment 2

[Erik Rose [:erik][:erikrose]]

It is likely. Hooray for fewer code paths. And thanks for the ticket gardening, Peter! :-D

Comment 3

[krishna.pendiala]

We can rank all the words by their tf-idf values and for a query with <3-chars we can return the one with highest tf-idf corresponding to that word. Tf-idf matrix of words ranks popular words in a document so any words which are close to the characters entered and have highest tf-idf can be returned.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

DXR is no longer available. Searchfox is now replacing it.
See meta bug 1669906 & https://groups.google.com/g/mozilla.dev.platform/c/jDRjrq3l-CY for more details.