Searching for <3-char strings returns all lines

UNCONFIRMED
Unassigned

Status

Webtools
DXR
UNCONFIRMED
2 years ago
2 years ago

People

(Reporter: erik, Unassigned)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(firefox40 affected)

Details

(Whiteboard: easy)

(Reporter)

Description

2 years ago
(This bug is for the es branch.)

Hitting Return to force a search for a shorter string than 3 chars causes all lines in the project to be returned. That's not useful. Since we can't do such a search with our trigram indexing, let's just refuse to do the search altogether, mirroring our AJAX search behavior when 2 chars are entered (which shows a bubble explaining that at least 3 chars are required to do a search).
(Reporter)

Updated

2 years ago
Whiteboard: easy
Can't reproduce any more, did we fix this in https://github.com/mozilla/dxr/pull/422?
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(erik)
(Reporter)

Comment 2

2 years ago
It is likely. Hooray for fewer code paths. And thanks for the ticket gardening, Peter! :-D
Flags: needinfo?(erik)
You need to log in before you can comment on or make changes to this bug.