1156469 - [Marketplace][Install] If an app install is cancelled, the user gets an error message that says "App install error: DOWNLOAD_CANCELED"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: App install Error Logcat

Description:
User sees incorrect error message after stopping an app installation that was initiated by the Marketplace. Then they are unable to install the app unless they download from the unfinished app on the homescreen, or if they delete that homescreen placeholder and go back into the marketplace and reinstall from there.


Repro Steps:
1) Update a Flame to 20150420010204
2) Open Marketplace
3) Search for the "Face Value" app
4) Tap on "Free" next to the first result
5) Tap "Install"> Qucikly pull down Notification tray> Tap on app download
6) Select "Stop Download"


Actual:
User sees the correct message that says "Face Value download stopped", then once that banner has clear the banner behind it is reveald and reads "App install error: DOWNLOAD_CANCELED". If the user tries to install the app again they get the error "App install error: REINSTALL_FORBIDDEN"


Expected:
User only sees the "Face Value download stopped" banner. If the user tries to reinstall the app, it can sucessfully be reinstalled


Notes: This bug can occur with any app, but the user needs to be able to have enough time to cancel the installation

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150420010204
Gaia: cb41d8421da5dc4f16ea566ea2917a9b7f828154
Gecko: 50b95032152c
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.


Repro frequency: 10/10
See attached: Logcat, Video - https://youtu.be/IjKsvl6dsMM

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on Flame 2.2, 2.1, and 2.0

User sees the correct message that says "Face Value download stopped", then once that banner has clear the banner behind it is reveald and reads "App install error: DOWNLOAD_CANCELED". If the user tries to install the app again they get the error "App install error: REINSTALL_FORBIDDEN"

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150416002504
Gaia: 8e24d8b7f5e7c74c3004b22710dda0dac3e04ead
Gecko: 41388836b5c6
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat)(Full Flash)
Build ID: 20150416001203
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: c54aa1be51d6
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Environmental Variables:
Device: Flame 2.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150416000205
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: bcbd45a97031
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI on Krupa to take a look, getting duplicated error messages.  Also edge case where app is registering as installed but has a stopped download icon on homescreen.

Comment 3

[Peter Bylenga [:PBylenga]]

Talked to Krupa offline, it's a platform issue, moving to homescreen.

Comment 4

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision and assignment.

Comment 5

[Hermes Cheng (inactive after July 27, 2015)]

Attachment: screenshot of installing app.png

It is not Marketplace problem. I believed there would be an icon like this attachment.

The reason is that the manifest URL has been added to DOMApplicationRegistry.webapps [1].

[1]https://github.com/mozilla/gecko-dev/blob/master/dom/apps/Webapps.jsm#L2584

Comment 6

[Hermes Cheng (inactive after July 27, 2015)]

Fabrice, could you take a look? Besides, I am not sure the component is correct.

Comment 7

[[:fabrice] Fabrice Desré]

The behavior here from the platform is expected. Gaia controls all the banner displayed. My guess is that we display "Face Value download stopped" as soon as the user confirms that he wants to cancel the dowload. I think gaia should actually wait for the DOWNLOAD_CANCEL event to display the banner.

Comment 8

[Hermes Cheng (inactive after July 27, 2015)]

Etienne, could you help this?

Comment 9

[Etienne Segonzac (:etienne)]

Looks like we're showing a generic error message in this case because we have no mapping for this error [1], but we're waiting for the event properly.

[1] https://github.com/mozilla-b2g/gaia/blob/0b166043ef2a1f235a4d7d4f40a51b625784195a/apps/system/js/app_install_manager.js#L18-27

Comment 10

[jgw9617]

Hello,

I can take this bug if no one else is interested? This will be my first bug fix on Gaia.

Thanks,
Justin

Comment 11

[jgw9617]

(In reply to Etienne Segonzac (:etienne) from comment #9)
> Looks like we're showing a generic error message in this case because we
> have no mapping for this error [1], but we're waiting for the event properly.
> 
> [1]
> https://github.com/mozilla-b2g/gaia/blob/
> 0b166043ef2a1f235a4d7d4f40a51b625784195a/apps/system/js/app_install_manager.
> js#L18-27

Hello,

I can take this bug if no one else is interested? This will be my first bug fix on Gaia.

Thanks,
Justin

Comment 12

[Etienne Segonzac (:etienne)]

(In reply to jgw9617 from comment #11)
> (In reply to Etienne Segonzac (:etienne) from comment #9)
> > Looks like we're showing a generic error message in this case because we
> > have no mapping for this error [1], but we're waiting for the event properly.
> > 
> > [1]
> > https://github.com/mozilla-b2g/gaia/blob/
> > 0b166043ef2a1f235a4d7d4f40a51b625784195a/apps/system/js/app_install_manager.
> > js#L18-27
> 
> Hello,
> 
> I can take this bug if no one else is interested? This will be my first bug
> fix on Gaia.
> 
> Thanks,
> Justin

Hi Justin!
Just saw your message, did you get started? Do you need help?

Comment 13

[jgw9617]

Have only looked at the code so far, haven't actually started yet. I'm excited to start on it tonight!

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] durwasa-chakraborty:install-cancelled > mozilla-b2g:master

Comment 15

[Durwasa Chakraborty]

Comment on attachment 8690635 [details] [review]
[gaia] durwasa-chakraborty:install-cancelled > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/33320

Comment 16

[Etienne Segonzac (:etienne)]

Discussed offline.

Comment 17

[GitHub Autolander Bot]

Attachment: [gaia] durwasa-chakraborty:bug-download-error > mozilla-b2g:master

Comment 18

[Etienne Segonzac (:etienne)]

Comment on attachment 8692577 [details] [review]
[gaia] durwasa-chakraborty:bug-download-error > mozilla-b2g:master

Yes! All good!
Just waiting for a green try to merge.

Comment 19

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/ffd62f1de90978f7c7ef211d27ff2e0f87b9a429

And another bug fixed!

Comment 20

[Shally Li（leave from Mozilla）]

Hi Durwasa,

    This bug has been verified as "Fail" on the latest build of Flame master and Aries KK master by the STR in comment 0. Could you please help to take a look again?

Thank you very much.


--------------------------------------------------------------------------------------------------
Actual results: 
User sees the correct message that says "Face Value download stopped", then once that banner has clear the banner behind it is reveald and reads "App install error: DOWNLOAD_CANCELED". 
If the user tries to install the app again they get the error "App install error: REINSTALL_FORBIDDEN". 
If user goes to homescreen to re-download the app, it can be installed successfully.

See attachments: verify_fail_Flame_master.3gp and logcat_1158.txt
Reproduce rate: 10/10


Device: Flame master_512mb (Fail)
Build ID               20151222030233
Gaia Revision          f3cf488a97ecaec43369f3e3d8a7dda52be019f9
Gaia Date              2015-12-22 02:20:26
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ad16863d1d45bd3fd7906c76fa1ac1e12d24a133
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151222.071644
Firmware Date          Tue Dec 22 07:16:57 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Fail)
Build ID               20151222115209
Gaia Revision          f3cf488a97ecaec43369f3e3d8a7dda52be019f9
Gaia Date              2015-12-22 02:20:26
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ad16863d1d45bd3fd7906c76fa1ac1e12d24a133
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151222.111221
Firmware Date          Tue Dec 22 11:12:28 UTC 2015
Bootloader             s1

Comment 21

[Shally Li（leave from Mozilla）]

Attachment: logcat_1158.txt

Comment 22

[Shally Li（leave from Mozilla）]

Attachment: verify_fail_Flame_master.3gp

Comment 23

[Etienne Segonzac (:etienne)]

(In reply to Shally Li from comment #20)
> Actual results: 
> User sees the correct message that says "Face Value download stopped", then
> once that banner has clear the banner behind it is reveald and reads "App
> install error: DOWNLOAD_CANCELED". 

This is bug 1228389.

Comment 24

[Shally Li（leave from Mozilla）]

Waiting for bug 1228389 landed/fixed.