Closed
Bug 1156485
Opened 11 years ago
Closed 11 years ago
[Settings] The 'Manage certificates' selection under the Wi-Fi menu fails to capitalize the 2nd word (certificates) to remain consistent with Settings menu capitalization conventions
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(b2g-v2.0 affected, b2g-v2.1 affected, b2g-v2.2 affected, b2g-master verified)
People
(Reporter: jmitchell, Assigned: arthurcc)
References
Details
(Keywords: polish, Whiteboard: [3.0-Daily-Testing])
Attachments
(3 files, 1 obsolete file)
Description:
Under the Wifi settings menu, at the bottom, is an option 'Manage certificates'. The lack of capitalization on the 2nd word is inconsistent with the rest of the Settings app where all words are capitalized for menu selections.
Repro Steps:
1) Update a Flame to 20150420010204
2) Launch Settings App
3) Select Wi-Fi
4) Scroll to bottom of Wi-Fi settings page
Actual:
Inconsistent capitalization
Expected:
both words will be capitalized to remain consistent with other menu options
Environmental Variables:
Device: Flame 3.0 (KK, Nightly, Full Flashed, 319 mem)
Build ID: 20150420010204
Gaia: cb41d8421da5dc4f16ea566ea2917a9b7f828154
Gecko: 50b95032152c
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0
Repro frequency: 10/10
See attached: screenshot
| Reporter | ||
Comment 1•11 years ago
|
||
This issue occurs in Flame 2.2, 2.1 and 2.0 also
Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150420002502
Gaia: c15a2b6d3a783813959c2b3bffd2a131f4270b9e
Gecko: cc02ee38b252
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Device: Flame 2.1 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150420001205
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: b85d4f4a6d61
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Device: Flame 2.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150420000202
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: c17fa8ed09c7
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Comment 2•11 years ago
|
||
NI on component owner for tracking, It's a polish issue.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga) → needinfo?(gchang)
Comment 3•11 years ago
|
||
Hi Arthur,
This is for better user experience.
This might need your help.
Flags: needinfo?(gchang) → needinfo?(arthur.chen)
| Assignee | ||
Comment 4•11 years ago
|
||
Okay, I'll fix it.
Assignee: nobody → arthur.chen
Flags: needinfo?(arthur.chen)
Comment 5•11 years ago
|
||
| Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8595174 [details] [review]
[gaia] crh0716:1156485 > mozilla-b2g:master
EJ, the patch fixes the capitalization of the certificate panels. Would you mind take a look at it? Thanks.
Attachment #8595174 -
Flags: review?(ejchen)
Comment 7•11 years ago
|
||
Comment on attachment 8595174 [details] [review]
[gaia] crh0716:1156485 > mozilla-b2g:master
Thanks Arthur ! r+ :)
Attachment #8595174 -
Flags: review?(ejchen) → review+
Updated•11 years ago
|
Keywords: checkin-needed
Comment 9•11 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/5915f64df5ecd4e2666616ab55f0faf644d27fd3
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 11•11 years ago
|
||
Per Comment 9,this bug has been fixed on master.
According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v3.0.
Actual results:Both words "Manage Certificates" are capitalized to remain consistent with other menu options.
See attachment: verified_v3.0.png
Reproduce rate: 0/5
---------------------------------------------------------------------
Device: Flame 3.0 build(Pass)
Build ID 20150422160203
Gaia Revision 9d4f756aa35cb7f030a92f3c1f65fb55254ddd1d
Gaia Date 2015-04-22 17:32:36
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/a9311ec2dd39
Gecko Version 40.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150422.193515
Firmware Date Wed Apr 22 19:35:27 EDT 2015
Bootloader L1TC000118D0
Leaving "verifyme" for v2.2&2.1&2.0 uplift.
Comment 12•11 years ago
|
||
Updated•11 years ago
|
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
Comment 13•11 years ago
|
||
Updated•11 years ago
|
Attachment #8596352 -
Attachment is obsolete: true
Comment 14•11 years ago
|
||
Why manageCert title string was removed and manageCertificates menu position string was added in its place?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 15•11 years ago
|
||
You're right, but reopening bugs doesn't make sense, file new ones (I'll do it).
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•