Closed Bug 1156499 Opened 5 years ago Closed 4 years ago

Disable non-profiler components

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

37 Branch
x86
macOS
defect

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

(Whiteboard: [polish-backlog])

Attachments

(1 file, 1 obsolete file)

For Fx40.0 release, we'll need to disable many of the newer features in the performance tool until the 40.1 release to bring it back to parity with the profiler in Fx39. We have some support toggling in place for FxOS so we can probably use similar techniques.

* Disable all detail views other than the js call tree
* Disable the overview graph, marker filter button
* Disable memory graph
* Hide most of the options (keep gecko data, invert call tree, flatten call tree)
* Re-enable the timeline tool
Blocks: perf-tool-v2
Whiteboard: [devedition-40]
This can be disabled via pref. Merge is on May 11th.
Priority: -- → P1
I just realized this is going to destroy all of our tests.
Assignee: nobody → jsantell
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> I just realized this is going to destroy all of our tests.

There was a beer emoji in comment 3. I guess somebody already drank it.
Status: NEW → ASSIGNED
Bug 1160313 already blocks v2.
No longer blocks: perf-tool-v2
Comment on attachment 8600105 [details] [diff] [review]
1156499-disable-everything.patch

Review of attachment 8600105 [details] [diff] [review]:
-----------------------------------------------------------------

SO RETRO

::: browser/app/profile/firefox.js
@@ +1448,5 @@
> +// TODO bug 1160313
> +#if MOZ_UPDATE_CHANNEL == aurora
> +  pref("devtools.performance.ui.retro-mode", true);
> +#else
> +  pref("devtools.performance.ui.retro-mode", false);

lol retro mode

::: browser/devtools/performance/performance-controller.js
@@ +292,2 @@
>      let options = {
> +      withMarkers: superMode ? true : false,

super mode

::: browser/devtools/performance/views/details.js
@@ +94,5 @@
>      let invalidCurrentView = false;
>  
>      for (let [name, { view }] of Iterator(this.components)) {
> +      // TODO bug 1160313 get rid of retro mode checks.
> +      let RETRO = PerformanceController.getOption("retro-mode");

Nit: s/RETRO/isRetro/g
Attachment #8600105 - Flags: review?(vporof) → review+
nits fixed
Attachment #8600105 - Attachment is obsolete: true
Attachment #8600191 - Flags: review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/211fa8dd7c24
Whiteboard: [devedition-40] → [devedition-40][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/211fa8dd7c24
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [devedition-40][fixed-in-fx-team] → [devedition-40]
Target Milestone: --- → Firefox 40
Flags: qe-verify-
Whiteboard: [devedition-40] → [polish-backlog]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.