Closed
Bug 1156499
Opened 9 years ago
Closed 9 years ago
Disable non-profiler components
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
(Whiteboard: [polish-backlog])
Attachments
(1 file, 1 obsolete file)
12.58 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
For Fx40.0 release, we'll need to disable many of the newer features in the performance tool until the 40.1 release to bring it back to parity with the profiler in Fx39. We have some support toggling in place for FxOS so we can probably use similar techniques. * Disable all detail views other than the js call tree * Disable the overview graph, marker filter button * Disable memory graph * Hide most of the options (keep gecko data, invert call tree, flatten call tree) * Re-enable the timeline tool
Assignee | ||
Updated•9 years ago
|
Blocks: perf-tool-v2
Whiteboard: [devedition-40]
Assignee | ||
Comment 1•9 years ago
|
||
This can be disabled via pref. Merge is on May 11th.
Updated•9 years ago
|
Priority: -- → P1
Assignee | ||
Comment 2•9 years ago
|
||
I just realized this is going to destroy all of our tests.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jsantell
Comment 3•9 years ago
|
||
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2) > I just realized this is going to destroy all of our tests.
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•9 years ago
|
||
Sadness ensues https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdad1f394606
Attachment #8600105 -
Flags: review?(vporof)
Comment 7•9 years ago
|
||
Comment on attachment 8600105 [details] [diff] [review] 1156499-disable-everything.patch Review of attachment 8600105 [details] [diff] [review]: ----------------------------------------------------------------- SO RETRO ::: browser/app/profile/firefox.js @@ +1448,5 @@ > +// TODO bug 1160313 > +#if MOZ_UPDATE_CHANNEL == aurora > + pref("devtools.performance.ui.retro-mode", true); > +#else > + pref("devtools.performance.ui.retro-mode", false); lol retro mode ::: browser/devtools/performance/performance-controller.js @@ +292,2 @@ > let options = { > + withMarkers: superMode ? true : false, super mode ::: browser/devtools/performance/views/details.js @@ +94,5 @@ > let invalidCurrentView = false; > > for (let [name, { view }] of Iterator(this.components)) { > + // TODO bug 1160313 get rid of retro mode checks. > + let RETRO = PerformanceController.getOption("retro-mode"); Nit: s/RETRO/isRetro/g
Attachment #8600105 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 8•9 years ago
|
||
nits fixed
Attachment #8600105 -
Attachment is obsolete: true
Attachment #8600191 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/211fa8dd7c24
Whiteboard: [devedition-40] → [devedition-40][fixed-in-fx-team]
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/211fa8dd7c24
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [devedition-40][fixed-in-fx-team] → [devedition-40]
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
Flags: qe-verify-
Updated•9 years ago
|
Whiteboard: [devedition-40] → [polish-backlog]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•