1156499 - Disable non-profiler components

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Jordan Santell [:jsantell] [@jsantell]]

For Fx40.0 release, we'll need to disable many of the newer features in the performance tool until the 40.1 release to bring it back to parity with the profiler in Fx39. We have some support toggling in place for FxOS so we can probably use similar techniques.

* Disable all detail views other than the js call tree
* Disable the overview graph, marker filter button
* Disable memory graph
* Hide most of the options (keep gecko data, invert call tree, flatten call tree)
* Re-enable the timeline tool

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

This can be disabled via pref. Merge is on May 11th.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

I just realized this is going to destroy all of our tests.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> I just realized this is going to destroy all of our tests.

Comment 4

[Victor Porof [:vporof][:vp]]

There was a beer emoji in comment 3. I guess somebody already drank it.

Comment 5

[Victor Porof [:vporof][:vp]]

Bug 1160313 already blocks v2.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1156499-disable-everything.patch

Sadness ensues
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdad1f394606

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 8600105 [details] [diff] [review]
1156499-disable-everything.patch

Review of attachment 8600105 [details] [diff] [review]:
-----------------------------------------------------------------

SO RETRO

::: browser/app/profile/firefox.js
@@ +1448,5 @@
> +// TODO bug 1160313
> +#if MOZ_UPDATE_CHANNEL == aurora
> +  pref("devtools.performance.ui.retro-mode", true);
> +#else
> +  pref("devtools.performance.ui.retro-mode", false);

lol retro mode

::: browser/devtools/performance/performance-controller.js
@@ +292,2 @@
>      let options = {
> +      withMarkers: superMode ? true : false,

super mode

::: browser/devtools/performance/views/details.js
@@ +94,5 @@
>      let invalidCurrentView = false;
>  
>      for (let [name, { view }] of Iterator(this.components)) {
> +      // TODO bug 1160313 get rid of retro mode checks.
> +      let RETRO = PerformanceController.getOption("retro-mode");

Nit: s/RETRO/isRetro/g

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1156499-disable-everything.patch

nits fixed

Comment 9

[Jordan Santell [:jsantell] [@jsantell]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/211fa8dd7c24

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/211fa8dd7c24