1156502 - [Settings] 'No imported certificate' could use better grammar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: ManageCert.png

Description:
If you are referring to an item that there can be multiple of then you should use the plural making 'No imported certificate' into 'No imported certificates'. The general consensus here is that this change still sounds awkward and might be improved upon by changing it to 'No certificates imported'


Repro Steps:  (pre-req: have no certificates)
1) Update a Flame to 20150420010204
2) Launch Settings App
3) Select Wi-Fi
4) Select manage certificates 


Actual:
'No imported certificate' grammar could be improved upon


Expected:
No imported certificateS
-or-
No certificates imported


Environmental Variables:
Device: Flame 3.0
Build ID: 20150420010204
Gaia: cb41d8421da5dc4f16ea566ea2917a9b7f828154
Gecko: 50b95032152c
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0



Repro frequency: 10/10
See attached: screenshot

Comment 1

[Joshua Mitchell (Inactive)]

This issue also occurs in Flame 2.2, 2.1, and 2.0

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150420002502
Gaia: c15a2b6d3a783813959c2b3bffd2a131f4270b9e
Gecko: cc02ee38b252
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Device: Flame 2.1 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150420001205
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: b85d4f4a6d61
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150420000202
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: c17fa8ed09c7
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI component owner for tracking this is a polish issue.

Comment 3

[Hermes Cheng (inactive after July 27, 2015)]

EJ,

It is a small change for settings.properties [1]. Could you take a look?

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L121

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] EragonJ:bug-1156502 > mozilla-b2g:master

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8595164 [details] [review]
[gaia] EragonJ:bug-1156502 > mozilla-b2g:master

Arthur, can you help me review this simple patch ?  thanks !

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Arthur, in this patch, I also refactored code a little bit, take DOMRequest for example, it supports promise now so I thought it would be nice if we can use that to make our codebase more consistent.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8595164 [details] [review]
[gaia] EragonJ:bug-1156502 > mozilla-b2g:master

r=me, thank you!

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/eb3ee5e2b9bf14e133319be605e255073bf870e4

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8595164 [details] [review]
[gaia] EragonJ:bug-1156502 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: wordings are not so intuitive to native English speakers
[Testing completed]: yes, with manual test
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: yes

Comment 10

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v3.0.  

Results:It shows 'No certificates imported' as expected.
See attachment: verified_v3.0.png
Reproduce rate: 0/5


Device: Flame 3.0 build(Pass)
Build ID               20150421160203
Gaia Revision          15134b080b5f406e5aa36f5136c17dafb4e31f64
Gaia Date              2015-04-21 19:52:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/86725d1a2cf3
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.192130
Firmware Date          Tue Apr 21 19:21:42 EDT 2015
Bootloader             L1TC000118D0
-----------------------------------------
Leaving "verifyme" for v2.2&2.1&2.0 uplift.

Comment 11

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.png

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/89f0b4094cc73f767ffd6919f7e33aa7399e813e

Comment 13

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v2.2.  

Results:It shows 'No certificates imported' as expected.
See attachment: verified_v2.2.png
Reproduce rate: 0/5


Device: Flame 2.2 build(Pass)
Build ID               20150426002504
Gaia Revision          265ca0bc9408c21fc4b25a259fcee7fb642cd06b
Gaia Date              2015-04-24 19:13:28
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1908685d798d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150426.043030
Firmware Date          Sun Apr 26 04:30:42 EDT 2015
Bootloader             L1TC000118D0

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.png

Comment 15

[Shally Li（leave from Mozilla）]

The bug has verified, clear verifyme keywords.