Closed Bug 1156513 Opened 9 years ago Closed 9 years ago

[Build] Include WebMaker app

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: drs, Assigned: drs)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

Include WebMaker app.
42 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
Let's pull the WebMaker app into the Spark/Ignite build.
Attached file Include WebMaker app. — 

        Attachment #8594981 -
        Flags: review?(kgrandon)

    
    

    
  
Comment on attachment 8594981 [details] [review]
Include WebMaker app.

I am relatively weak at Makefile, but this looks good to me.

        Attachment #8594981 -
        Flags: review?(kgrandon) → review+

    
    

    
  
Yeah. Ideally we can ask the build system peers for review on patches to this from now on, and even more ideally, kill this repo entirely.

https://github.com/fxos/lightsaber/commit/885325487cfdf2afef7ec5c27d98aa2584b800fb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [ignite] → [spark]

    
  
Blocks: spark-build
No longer blocks: spark
Component: Gaia → Gaia::Build

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: