1156514 - [Merge Duplicates] Tapping the middle of a listed duplicate contact results shows up a confirmation dialog instead of unselecting the contact

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-merge-detail-selection.txt

Description:
When the user is at the Merge Duplicates screen, if they tap toward the left side of a listed contact, the contact will be have its check mark toggled, but if the user taps the middle or right side of the same contact, the Duplicate Element details screen will appear for that contact.

There is no visual indicator for the user to expect that tapping the right end of the contact will produce different functionality than tapping the left end. This is not affected by a difference in contact name length. The user is not visibly informed that they are able to view the duplicate contact elements at all.  The user will expect some kind of visual indication of the difference in functionality between

Repro Steps:
1) Update a Flame to 20150420010204
2) Launch contacts
3) Create a contact with a phone number
4) Create a second contact with the same phone number
5) At the Merge Duplicates screen, Tap the left end of the listed duplicate contact
6) Tap the middle or right end of the listed duplicate contact.

Actual:
Tapping the left end will toggle the check mark (tick) on or off, while tapping in the middle or on the right end will open the Duplicate Element screen.

Expected:
Tapping on the contact produces the same functionality regardless of where on the contact name the tap occurs, unless there is a distinct icon (Possibly an ellipsis "...") to visually indicate separate functionality.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150420010204
Gaia: cb41d8421da5dc4f16ea566ea2917a9b7f828154
Gecko: 50b95032152c
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Repro frequency: 10/10
See attached: Logcat, Video (URL)

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.2, 2.1 and 2.0 builds
Tapping the left end will toggle the check mark (tick) on or off, while tapping in the middle or on the right end will open the Duplicate Element screen.

Environmental Variables:
Device: Flame 2.2 (319MB)(Full Flash)
Build ID: 20150420002502
Gaia: c15a2b6d3a783813959c2b3bffd2a131f4270b9e
Gecko: cc02ee38b252
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Environmental Variables:
Device: Flame 2.1 (319MB)(Full Flash)
Build ID: 20150420001205
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: b85d4f4a6d61
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.0 (319MB)(Full Flash)
Build ID: 20150420000202
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: c17fa8ed09c7
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI component owner for nomination decision and assignment.

Comment 3

[Johan Lorenzo [:jlorenzo]]

That's due to the fact that the hitbox of a checkbox is bigger than the checkbox itself. Reducing it to the size of the checkbox would make it harder to tap. I'm not sure this action needs to be fixed. Asking Carrie to confirm it.

Comment 4

[Carrie Wang [New account: [e-mail]]]

Hi, 

Agree on this one. The "tapping" should only function for "selecting" on this page no matter it's on the left, middle or the right side. So the pop up window is a bug and should be removed. Thanks!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Hi just to give a bit of clarity on the current behaviour:

In LTR:
20% of the width: selecting
80% of the width: showing details

RTL:
80% of the width: showing details
20%: selecting

That was done in purpose, and to me is one of the most confusing patterns ever. The popup wasn't a bug, again, was something that previous UX owner added to show what are the details of the contact that you want to merge. That popup contains information about the contact to differentiate between contacts.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

triage team: p1, needs to be solved, but we need UX input, to discern how are we going to make the selection or show the popup that displays extra information to know which contacts you want to merge.

Requesting new ux for this, Harly can you help?

Comment 7

[Harly Hsu[:harly]]

Hi Francisco, we currently are short-handed and do not have a dedicate UX for comms, but I will try to help as much as possible. Currently we don't have a pattern in which 2 actions are presented in select mode. May I ask is it really necessary to have the ability to display extra contact information? If not, we can just go with what Carrie suggested in Comment 4 and just allow the user to select contacts.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

The need was just for being able to differentiate 2 possible contacts with same name and surname but different email and phone number.

If you agree with Carrie's comment I'll go for removing the double functionality.

Thanks

Comment 9

[Harly Hsu[:harly]]

Yes, I think I agree on removing the double functionality for the sake of consistency and pattern.
Thanks.

Comment 10

[Johan Lorenzo [:jlorenzo]]

Comms triage: Based on comment 6

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

This functionality has been already implemented. No middle zones anymore.