BaseMargin<T>::Side casts enum SideT to T and adds to pointer

RESOLVED FIXED in Firefox 40

Status

()

defect
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: lsalzman, Assigned: lsalzman)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The Side(SideT) methods in gfx/BaseMargin<T> cast the SideT argument to a value of type T before adding it to a pointer. It should rather be cast to an int, as T is sometimes a Float (as instantiated in Rect.h).
(Assignee)

Updated

4 years ago
Attachment #8595011 - Flags: review+
(Assignee)

Updated

4 years ago
Attachment #8595011 - Flags: review+ → review?(jmuizelaar)
(Assignee)

Updated

4 years ago
Attachment #8595011 - Flags: checkin?
Attachment #8595011 - Flags: review?(jmuizelaar)
Attachment #8595011 - Flags: review+
Attachment #8595011 - Flags: checkin?
https://hg.mozilla.org/mozilla-central/rev/cd4dc49dd573
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.