Closed
Bug 1156536
Opened 9 years ago
Closed 9 years ago
BaseMargin<T>::Side casts enum SideT to T and adds to pointer
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
Details
Attachments
(1 file)
|
463 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
The Side(SideT) methods in gfx/BaseMargin<T> cast the SideT argument to a value of type T before adding it to a pointer. It should rather be cast to an int, as T is sometimes a Float (as instantiated in Rect.h).
|
Assignee | |
Updated•9 years ago
|
Attachment #8595011 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8595011 -
Flags: review+ → review?(jmuizelaar)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8595011 -
Flags: checkin?
|
||
Updated•9 years ago
|
Attachment #8595011 -
Flags: review?(jmuizelaar)
Attachment #8595011 -
Flags: review+
Attachment #8595011 -
Flags: checkin?
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 1•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd4dc49dd573
Keywords: checkin-needed
|
|
||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd4dc49dd573
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•