The default bug view has changed. See this FAQ.

Fix Telemetry histograms that expired in version 40

RESOLVED FIXED in Firefox 40

Status

()

Toolkit
Telemetry
RESOLVED FIXED
2 years ago
9 months ago

People

(Reporter: vladan, Assigned: vladan)

Tracking

(Blocks: 1 bug)

unspecified
mozilla40
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This bug deals with Telemetry histograms that were set to expire in version 40. 

I fixed the expiry dates for histograms which were not supposed to expire.
I added comments to the histogram's description field for histograms that did need to expire. The owners of those histograms need to remove their expired histogram and the accumulation code.
(Assignee)

Comment 1

2 years ago
Created attachment 8595043 [details] [diff] [review]
fix_expired.patch

Moved the patch out of bug 1136118
Attachment #8595043 - Flags: review?(rvitillo)
(Assignee)

Comment 2

2 years ago
The patch fixes probe expiry dates based on the following data sources:

1. Emails and conversation summarized in https://etherpad.mozilla.org/telemetryprobes40
2. Comments in bug 1045108
3. Comments in bug 1149284
Assignee: nobody → vdjeric
the moz_sqlite probes had been setup correctly at the last iteration over probes, now I see you set back all of them to expire on 50.
The ones marked as never were considered important, while the others could even go, nobody is using those cause they don't report interesting enough data.
Could you please avoid converting "never" to "50"? Anything else is ok.
We can also file a bug to remove the not-never probes imo.

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/843442ce3f07
(Assignee)

Comment 5

2 years ago
Comment on attachment 8595043 [details] [diff] [review]
fix_expired.patch

Landed, with Roberto's r+ and Mak's objections applied

https://hg.mozilla.org/integration/mozilla-inbound/rev/843442ce3f07
Attachment #8595043 - Flags: review?(rvitillo) → review+
https://hg.mozilla.org/mozilla-central/rev/843442ce3f07
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Blocks: 1150529
Blocks: 1281793
No longer blocks: 1281793
You need to log in before you can comment on or make changes to this bug.