Closed Bug 1156581 Opened 7 years ago Closed 6 years ago

Crash [@ nsSVGEffects::InvalidateRenderingObservers]

Categories

(Core :: SVG, defect)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox40 --- affected
firefox46 --- fixed

People

(Reporter: jruderman, Assigned: longsonr)

References

(Blocks 1 open bug)

Details

(Keywords: crash, testcase)

Attachments

(3 files)

Attached image testcase
No description provided.
Attached file stack
Assignee: nobody → longsonr
Comment on attachment 8702939 [details] [diff] [review]
GetContent() returns null so give up rather than crashing

Review of attachment 8702939 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good -- thanks for picking this up.

I poked around in GDB a bit, because I was curious why we have a null content-pointer here & if there's a deeper problem. Looks like it's null because the frame in question is the root frame, i.e. the ViewportFrame, and that seems to have a null content-pointer. (which I think is as-expected -- at least, it's true of another HTML pageload that I just did.) And we're invalidating the ViewportFrame's rendering observers via the last few lines in nsCSSFrameConstructor.cpp's "InvalidateCanvasIfNeeded" function, which explicitly invalidates the viewport.

So, I think this makes sense. r=me
Attachment #8702939 - Flags: review?(dholbert) → review+
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/eb4dc9b5a928
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.