1156596 - [System] Support device type in base module

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

We already had device type information in system app. If a module has its owned sub-modules among different device types, the base module should have the ability to dynamic load the sub modules by device types.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

The proposal we have is:

*. change the SUB_MODULES variable from array to object, like:
   {
     'default': ['module1', 'module2'],
     'phone': ['module3'],
     'tv': ['moduletv']
   }

*. At _startSubModules, _initialSubModule, _stopSubModules, we only creates and calls |default| + |device typed|, like phone or tv, list.

*. If SUB_MODULES variable is still array, we view this array as 'phone' to be backward compatible.

*. File bugs to migrate all existing modules' SUB_MODULES from array to object.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

I will take this back once I have time to work on it.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Hey I'd like to take this when I feel free. I think it's a good starting point to learn about system app.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:basemodule > mozilla-b2g:master

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8633958 [details] [review]
[gaia] rickychien:basemodule > mozilla-b2g:master

Hey John, here my first patch for system app and please review it kindly.

1. To support a default and different device type for base_module, the new SUB_MODULES list would merge default type modules and a given device type modules. 

2. I also migrate all existing modules's SUB_MODULES from array to object.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

(In reply to Ricky Chien [:rickychien] from comment #5)
> Comment on attachment 8633958 [details] [review]
> [gaia] rickychien:basemodule > mozilla-b2g:master
> 
> Hey John, here my first patch for system app and please review it kindly.
> 
> 1. To support a default and different device type for base_module, the new
> SUB_MODULES list would merge default type modules and a given device type
> modules. 
> 
> 2. I also migrate all existing modules's SUB_MODULES from array to object.

Ricky,

Thanks for this hard work. To prevent a big patch, we, alive and I, would like to see BaseModule to support fallback mechanism. Existing modules can use an object which implied to phone. If TV needs that module, we change should change that module to support device type. Please see comment 1.

BTW, we should email to dev-gaia to notify other devs this change.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Backward compatible mechanism is ready for review. I'm going to write a test and additional comments for this new feature before setting r?=johnhu.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8633958 [details] [review]
[gaia] rickychien:basemodule > mozilla-b2g:master

Done. Set review flag to johnhu.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8633958 [details] [review]
[gaia] rickychien:basemodule > mozilla-b2g:master

Looks good to me overall. But please revert the __DEVICE_TYPE__ part. We shouldn't use this variable at too many places. We should keep it only at feature_detector.js.

Comment 10

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8633958 [details] [review]
[gaia] rickychien:basemodule > mozilla-b2g:master

Nice work! :)

Comment 11

[Ricky Chien [:rickychien] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=9b0d970c24135eff049c1c5c273a4e2713a2e3fc

all green, ready to land

Comment 12

[Ricky Chien [:rickychien] (inactive)]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/b1ca30da064301abaa824cd2376227478ec15f41