Closed Bug 1156609 Opened 9 years ago Closed 9 years ago

Fix remaining Settings jshint issues

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1156145

People

(Reporter: kgrandon, Unassigned)

References

Details

Which means removing these files from xfail.list: https://github.com/mozilla-b2g/gaia/blob/0645bbed4d6cbd8064652eebafe011edc3e417fd/build/jshint/xfail.list#L65-L95

We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!
Hey Arthur - I'm looking at trying to have all of these jshint failures cleaned up in the next few weeks. Just wondering if you or someone on your team wanted to take this before I jumped on it. If not I'll gladly take this and maybe request a review from you. Thanks!
Flags: needinfo?(arthur.chen)
Hi Kevin, we are already working on this on bug 1156145. Maybe I just make it block bug 1084191?
Flags: needinfo?(arthur.chen)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.