Closed Bug 1156610 Opened 8 years ago Closed 8 years ago

Fix remaining communications jshint issues

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Unassigned)

References

Details

Attachments

(1 file)

[gaia] arcturus:bug-1156610 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
Which means removing these files from xfail.list: https://github.com/mozilla-b2g/gaia/blob/0645bbed4d6cbd8064652eebafe011edc3e417fd/build/jshint/xfail.list#L1-L7

We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!
Hey Francisco - I'm looking at trying to have all of these jshint failures cleaned up in the next few weeks. Just wondering if you wanted to take this before I jumped on it. If not I'll gladly take this and maybe request a review from you. Thanks!
Flags: needinfo?(francisco)
Or Jose - would this be something that you would want to work on?
Flags: needinfo?(jmcf)
Comment on attachment 8597701 [details] [review]
[gaia] arcturus:bug-1156610 > mozilla-b2g:master

Hei Kevin,

can you take a quick look?
Flags: needinfo?(francisco)
Attachment #8597701 - Flags: review?(kgrandon)
Comment on attachment 8597701 [details] [review]
[gaia] arcturus:bug-1156610 > mozilla-b2g:master

Awesome, thank you! I also left a small comment on github which you may want to address before landing.
Flags: needinfo?(jmcf)
Attachment #8597701 - Flags: review?(kgrandon) → review+
Thanks Kevin,

left a comment on GH about disabling the check unused variables.

And landed this here:

https://github.com/mozilla-b2g/gaia/commit/27de2db07cf29922558f5fdf7b68bc44aba778e8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.