1156612 - Fix remaining video jshint issues

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Kevin Grandon :kgrandon]

Which means removing these files from xfail.list: https://github.com/mozilla-b2g/gaia/blob/0645bbed4d6cbd8064652eebafe011edc3e417fd/build/jshint/xfail.list#L110-L128

We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!

Comment 1

[Kevin Grandon :kgrandon]

Hey Russ - I'm looking at trying to have all of these jshint failures cleaned up in the next few weeks. I saw that you were active on the video app recently and was wondering if you or someone on your team wanted to take this. If not I'll gladly take this and maybe request a review from you. Thanks!

Comment 2

[Russ Nicoletti [:russn]]

I will take a run at it.

Comment 3

[Kevin Grandon :kgrandon]

Hey Russ - any chance you have cycles to work on this this week? If not I'm happy to take it, thanks!

Comment 4

[Russ Nicoletti [:russn]]

Attachment: Link to github PR: https://github.com/mozilla-b2g/gaia/pull/29753

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8598257 [details] [review]
Link to github PR: https://github.com/mozilla-b2g/gaia/pull/29753

Very happy to see these files fixed, thank you! I left a few comments on github which you may want to address before landing. I'd recommend leaving the $ function alone for the time being.

Please update the commit message to contain the bug number, and re-flag me if you need me to take another look.

Comment 6

[Russ Nicoletti [:russn]]

Master: https://github.com/mozilla-b2g/gaia/commit/70f69dd51991ab98c34269919e1adc7aeabc8320