Fix remaining video jshint issues

RESOLVED FIXED in 2.2 S12 (15may)

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: rnicoletti)

Tracking

unspecified
2.2 S12 (15may)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Which means removing these files from xfail.list: https://github.com/mozilla-b2g/gaia/blob/0645bbed4d6cbd8064652eebafe011edc3e417fd/build/jshint/xfail.list#L110-L128

We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!
(Reporter)

Comment 1

3 years ago
Hey Russ - I'm looking at trying to have all of these jshint failures cleaned up in the next few weeks. I saw that you were active on the video app recently and was wondering if you or someone on your team wanted to take this. If not I'll gladly take this and maybe request a review from you. Thanks!
Flags: needinfo?(rnicoletti)
(Assignee)

Comment 2

3 years ago
I will take a run at it.
Assignee: nobody → rnicoletti
Status: NEW → ASSIGNED
Flags: needinfo?(rnicoletti)
(Reporter)

Comment 3

3 years ago
Hey Russ - any chance you have cycles to work on this this week? If not I'm happy to take it, thanks!
Flags: needinfo?(rnicoletti)
Target Milestone: --- → 2.2 S12 (15may)
(Assignee)

Comment 4

3 years ago
Created attachment 8598257 [details] [review]
Link to github PR: https://github.com/mozilla-b2g/gaia/pull/29753
Flags: needinfo?(rnicoletti)
Attachment #8598257 - Flags: review?(kgrandon)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8598257 [details] [review]
Link to github PR: https://github.com/mozilla-b2g/gaia/pull/29753

Very happy to see these files fixed, thank you! I left a few comments on github which you may want to address before landing. I'd recommend leaving the $ function alone for the time being.

Please update the commit message to contain the bug number, and re-flag me if you need me to take another look.
Attachment #8598257 - Flags: review?(kgrandon) → review+
(Assignee)

Comment 6

3 years ago
Master: https://github.com/mozilla-b2g/gaia/commit/70f69dd51991ab98c34269919e1adc7aeabc8320
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.