Closed Bug 1156635 Opened 5 years ago Closed 5 years ago

[Stingray][Contribution] Browser

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

defect

Tracking

(feature-b2g:2.5+)

RESOLVED FIXED
FxOS-S6 (04Sep)
feature-b2g 2.5+

People

(Reporter: hochang, Assigned: yifan)

References

Details

(Whiteboard: [ft:conndevices][partner-blocker])

Attachments

(1 file)

Stingray browser contribution
Priority: -- → P1
Assignee: nobody → yliao
Depends on: 1190158
Blocks: 1190158
No longer depends on: 1190158
Should remove proprietary API and functionality from the contributed code.
Status: NEW → ASSIGNED
feature-b2g: --- → 2.5+
Comment on attachment 8648660 [details] [review]
[gaia] begeeben:1156635_browser > mozilla-b2g:master

Please help review the partner contribution, thanks!

Please refer to https://github.com/begeeben/gaia/commits/tv_browser if detailed commit logs are needed.
Attachment #8648660 - Flags: review?(rexboy)
Target Milestone: --- → FxOS-S6 (04Sep)
Comment on attachment 8648660 [details] [review]
[gaia] begeeben:1156635_browser > mozilla-b2g:master

First, thanks for your effort to adapt these codes!

We have some issues that need to be take care. Please see my comments.
Attachment #8648660 - Flags: review?(rexboy)
Comment on attachment 8648660 [details] [review]
[gaia] begeeben:1156635_browser > mozilla-b2g:master

Thanks for the detailed review and notes! Please help to review the updated code, thanks!
Attachment #8648660 - Flags: review?(rexboy)
Comment on attachment 8648660 [details] [review]
[gaia] begeeben:1156635_browser > mozilla-b2g:master

Thank you!

please remove the redundant brand icon inside browser app and make sure the tests are all green before landing.
Attachment #8648660 - Flags: review?(rexboy) → review+
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-blocker]
Blocks: 1198099
Blocks: 1198103
Blocks: 1198115
Blocks: 1196624
Blocks: 1198200
Added Bug 1198115 - [browser] Rewrite browser_db_test.js to track test issues.
Added Bug 1198103 - [browser] Fix jshint errors to track jshint errors.
Added Bug 1196624 - Need official and unofficial 336 pixel Firefox branding icon for Firefox OS TV to track branding icon.
Added Bug 1198200 - [browser] Fix eslint errors to track eslint errors.
Comment on attachment 8648660 [details] [review]
[gaia] begeeben:1156635_browser > mozilla-b2g:master

Thanks Rex, I've separated the commit for the eslint errors. Will be rebased into 1 commit after review granted. By Ricky's comment, it should be alright without the error details after the hash tag.
Attachment #8648660 - Flags: review+ → review?(rexboy)
Comment on attachment 8648660 [details] [review]
[gaia] begeeben:1156635_browser > mozilla-b2g:master

Let's add some comments to describe those files before landing, see my comment.
Attachment #8648660 - Flags: review?(rexboy) → review+
Thanks Rex! Merged into master:

https://github.com/mozilla-b2g/gaia/pull/31371
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Hey guys, this code is using deprecated mozL10n.get API and will require a refactor. Can we make sure that our partners know that and stop using that API please?
The total number of calls to mozL10n.get in tv_apps/browser is 40.

I annotated them in the pull request and suggested fixes. :yifan, how do you want to handle that?
Flags: needinfo?(yliao)
Thank you Zibi! May I open a follow up bug to refactor mozL10n.get? Since we have many features depending on this bug, we would like to track the issue in another bug so that we could all work in parallel.
Flags: needinfo?(yliao) → needinfo?(gandalf)
Blocks: 1199563
Yeah! File a follow up pls :)
Flags: needinfo?(gandalf)
Blocks: 1200078
Thank you Zibi! We'll work on it in bug 1200078.
You need to log in before you can comment on or make changes to this bug.