Closed
Bug 1156636
Opened 9 years ago
Closed 9 years ago
Dragging a selection-caret starts panning at a large zoom-in scale
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: TYLin, Assigned: mtseng)
References
Details
Attachments
(3 files)
Steps to reproduce: 1. Open the attached html on B2G browser. 2. Pinch zoom-in the html to the scale as the attached image. 3. Long tap the text "456" to make selection-carets shown. 4. Drag a selection-caret. Actual result: APZ starts panning while dragging a selection-caret. Expected result: APZ does not panning while dragging a selection-caret.
Reporter | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
I can reproduce this problem intermittently, when trying to drag the starting caret to the left.
Comment 3•9 years ago
|
||
Whether or not the problem occurs is correlated with whether APZ hit testing for the touch-start returns HitLayer (we get panning) or HitDispatchToContentRegion (no panning).
Assignee | ||
Comment 4•9 years ago
|
||
In content side, event regions would multiply post scale(mParameters.mX/YScale) [1]. But apz perform hit test in layer coordinate space which means post scale doesn't consider in this space [2]. So, if we pinch-zoom, the event regions are wrong. I'll upload a patch which remove multiplying post scale in FrameLayerBuilder. [1]: https://dxr.mozilla.org/mozilla-central/source/layout/base/FrameLayerBuilder.cpp#3049 [2]: https://dxr.mozilla.org/mozilla-central/source/gfx/layers/apz/src/HitTestingTreeNode.cpp#179
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mtseng
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8598489 -
Flags: review?(roc)
Attachment #8598489 -
Flags: review?(roc) → review+
Comment 6•9 years ago
|
||
Why are we drawing the selection caret so big anyway? At really high zoom levels the carets take up half the screen. I thought we accounted for that somewhere and scaled them down so that they were always the same visual size?
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #6) > Why are we drawing the selection caret so big anyway? At really high zoom > levels the carets take up half the screen. I thought we accounted for that > somewhere and scaled them down so that they were always the same visual size? We are planning to implement it in bug 1068525!
Comment 8•9 years ago
|
||
Great, thanks!
Assignee | ||
Comment 9•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4db206f0d408 Looks like we have some infrastructure error in last try. Re-submit a try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=324e68a4bbaf
Assignee | ||
Comment 10•9 years ago
|
||
B2G ICS Emulator debug M20 looks like a known issue. Shouldn't relevent to this bug.
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9073aaaf9a6
Keywords: checkin-needed
Comment 13•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c9073aaaf9a6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•